Re: [Mesa-dev] [PATCH 02/29] anv/blorp: Rework image clear/resolve helpers

2018-01-12 Thread Jason Ekstrand
On Wed, Dec 6, 2017 at 9:56 AM, Nanley Chery wrote: > On Wed, Dec 06, 2017 at 09:40:25AM -0800, Nanley Chery wrote: > > On Tue, Dec 05, 2017 at 03:48:45PM -0800, Nanley Chery wrote: > > > On Mon, Nov 27, 2017 at 07:05:52PM -0800, Jason Ekstrand wrote: > > > > This replaces image_fast_clear and cc

Re: [Mesa-dev] [PATCH 02/29] anv/blorp: Rework image clear/resolve helpers

2018-01-12 Thread Jason Ekstrand
On Tue, Dec 5, 2017 at 4:16 PM, Nanley Chery wrote: > On Mon, Nov 27, 2017 at 07:05:52PM -0800, Jason Ekstrand wrote: > > This replaces image_fast_clear and ccs_resolve with two new helpers that > > simply perform an isl_aux_op whatever that may be on CCS or MCS. This > > is a bit cleaner as it

Re: [Mesa-dev] [PATCH 02/29] anv/blorp: Rework image clear/resolve helpers

2018-01-12 Thread Jason Ekstrand
On Tue, Dec 5, 2017 at 3:48 PM, Nanley Chery wrote: > On Mon, Nov 27, 2017 at 07:05:52PM -0800, Jason Ekstrand wrote: > > This replaces image_fast_clear and ccs_resolve with two new helpers that > > simply perform an isl_aux_op whatever that may be on CCS or MCS. This > > is a bit cleaner as it

Re: [Mesa-dev] [PATCH 02/29] anv/blorp: Rework image clear/resolve helpers

2017-12-06 Thread Nanley Chery
On Wed, Dec 06, 2017 at 09:40:25AM -0800, Nanley Chery wrote: > On Tue, Dec 05, 2017 at 03:48:45PM -0800, Nanley Chery wrote: > > On Mon, Nov 27, 2017 at 07:05:52PM -0800, Jason Ekstrand wrote: > > > This replaces image_fast_clear and ccs_resolve with two new helpers that > > > simply perform an is

Re: [Mesa-dev] [PATCH 02/29] anv/blorp: Rework image clear/resolve helpers

2017-12-06 Thread Nanley Chery
On Tue, Dec 05, 2017 at 03:48:45PM -0800, Nanley Chery wrote: > On Mon, Nov 27, 2017 at 07:05:52PM -0800, Jason Ekstrand wrote: > > This replaces image_fast_clear and ccs_resolve with two new helpers that > > simply perform an isl_aux_op whatever that may be on CCS or MCS. This > > is a bit cleane

Re: [Mesa-dev] [PATCH 02/29] anv/blorp: Rework image clear/resolve helpers

2017-12-05 Thread Nanley Chery
On Mon, Nov 27, 2017 at 07:05:52PM -0800, Jason Ekstrand wrote: > This replaces image_fast_clear and ccs_resolve with two new helpers that > simply perform an isl_aux_op whatever that may be on CCS or MCS. This > is a bit cleaner as it separates performing the aux operation from which > blorp help

Re: [Mesa-dev] [PATCH 02/29] anv/blorp: Rework image clear/resolve helpers

2017-12-05 Thread Nanley Chery
On Mon, Nov 27, 2017 at 07:05:52PM -0800, Jason Ekstrand wrote: > This replaces image_fast_clear and ccs_resolve with two new helpers that > simply perform an isl_aux_op whatever that may be on CCS or MCS. This > is a bit cleaner as it separates performing the aux operation from which > blorp help

[Mesa-dev] [PATCH 02/29] anv/blorp: Rework image clear/resolve helpers

2017-11-27 Thread Jason Ekstrand
This replaces image_fast_clear and ccs_resolve with two new helpers that simply perform an isl_aux_op whatever that may be on CCS or MCS. This is a bit cleaner as it separates performing the aux operation from which blorp helper we have to call to do it. --- src/intel/vulkan/anv_blorp.c | 2