Re: [Mesa-dev] [PATCH 02/26] nir: Use writemasked store_vars in glsl_to_nir.

2015-12-04 Thread Jason Ekstrand
Yeah, I like this. On Wed, Dec 2, 2015 at 4:15 PM, Kenneth Graunke wrote: > Instead of performing the read-modify-write cycle in glsl->nir, we can > simply emit a partial writemask. For locals, nir_lower_vars_to_ssa will > do the equivalent read-modify-write cycle for us, so we continue to get >

[Mesa-dev] [PATCH 02/26] nir: Use writemasked store_vars in glsl_to_nir.

2015-12-02 Thread Kenneth Graunke
Instead of performing the read-modify-write cycle in glsl->nir, we can simply emit a partial writemask. For locals, nir_lower_vars_to_ssa will do the equivalent read-modify-write cycle for us, so we continue to get the same SSA values we had before. Because glsl_to_nir calls nir_lower_outputs_to_