Re: [Mesa-dev] [PATCH 02/18] anv: Add a new block-based batch emit macro

2016-04-19 Thread Michael Schellenberger Costa
Hi Jason, stupid optional nitpick , but could you go for anv_batch_emit_block? Normally abbreviations below 3 characters aren't really worth it. Michael Am 19/04/2016 um 02:10 schrieb Jason Ekstrand: > This new macro uses a for loop to create an actual code block in which to > place the macro se

Re: [Mesa-dev] [PATCH 02/18] anv: Add a new block-based batch emit macro

2016-04-19 Thread Jason Ekstrand
On Mon, Apr 18, 2016 at 11:53 PM, Michael Schellenberger Costa < mschellenbergerco...@googlemail.com> wrote: > Hi Jason, > > stupid optional nitpick , but could you go for anv_batch_emit_block? > Normally abbreviations below 3 characters aren't really worth it. > Given that the last two patches d

Re: [Mesa-dev] [PATCH 02/18] anv: Add a new block-based batch emit macro

2016-04-18 Thread Ian Romanick
On 04/18/2016 05:19 PM, Ian Romanick wrote: > On 04/18/2016 05:10 PM, Jason Ekstrand wrote: >> This new macro uses a for loop to create an actual code block in which to >> place the macro setup code. One advantage of this is that you syntatically >

Re: [Mesa-dev] [PATCH 02/18] anv: Add a new block-based batch emit macro

2016-04-18 Thread Ian Romanick
On 04/18/2016 05:10 PM, Jason Ekstrand wrote: > This new macro uses a for loop to create an actual code block in which to > place the macro setup code. One advantage of this is that you syntatically syntactically > use braces instea

[Mesa-dev] [PATCH 02/18] anv: Add a new block-based batch emit macro

2016-04-18 Thread Jason Ekstrand
This new macro uses a for loop to create an actual code block in which to place the macro setup code. One advantage of this is that you syntatically use braces instead of parentheses. Another is that the code in the block doesn't even get executed if anv_batch_emit_dwords fails. --- src/intel/vu