Re: [Mesa-dev] [PATCH 02/17] i965/miptree: Zero-initialize CCS_D buffers

2018-05-03 Thread Nanley Chery
On Thu, May 03, 2018 at 12:40:49PM -0700, Jason Ekstrand wrote: > Good catch. Rb > Thanks! > On May 3, 2018 12:04:59 Nanley Chery wrote: > > > Before this patch, the aux_state was actually AUX_INVALID because the BO > > was never defined. This was fine on single slice miptrees because we > > w

Re: [Mesa-dev] [PATCH 02/17] i965/miptree: Zero-initialize CCS_D buffers

2018-05-03 Thread Jason Ekstrand
Good catch. Rb On May 3, 2018 12:04:59 Nanley Chery wrote: Before this patch, the aux_state was actually AUX_INVALID because the BO was never defined. This was fine on single slice miptrees because we would fast-clear the resource right after creation. For multi-slice miptrees on SKL+ however,

[Mesa-dev] [PATCH 02/17] i965/miptree: Zero-initialize CCS_D buffers

2018-05-03 Thread Nanley Chery
Before this patch, the aux_state was actually AUX_INVALID because the BO was never defined. This was fine on single slice miptrees because we would fast-clear the resource right after creation. For multi-slice miptrees on SKL+ however, this results in undefined behavior when accessing a non-base sl