Re: [Mesa-dev] [PATCH 02/16] radeonsi: Initial geometry shader support

2014-01-28 Thread Vadim Girlin
On Wed, 2014-01-29 at 07:13 +1000, Dave Airlie wrote: > >> 3) In si_init_gs_rings: > >> - could you please use readable decimal numbers for specifying the > >> sizes? Like 1024 * 1024 * ... > > [...] > >> - isn't 64 MB too many for a ring buffer? > > > > I can write the numbers any way you like. :)

Re: [Mesa-dev] [PATCH 02/16] radeonsi: Initial geometry shader support

2014-01-28 Thread Dave Airlie
>> 3) In si_init_gs_rings: >> - could you please use readable decimal numbers for specifying the >> sizes? Like 1024 * 1024 * ... > [...] >> - isn't 64 MB too many for a ring buffer? > > I can write the numbers any way you like. :) But I just copied them from > the corresponding r600g patches; I do

Re: [Mesa-dev] [PATCH 02/16] radeonsi: Initial geometry shader support

2014-01-28 Thread Michel Dänzer
On Sam, 2014-01-25 at 02:21 +0100, Marek Olšák wrote: > On Fri, Jan 24, 2014 at 10:19 PM, Marek Olšák wrote: > > 1) Do we really have to have so much code inside #if...#endif? Can we > > always compile everything and just not set the pipe_context functions > > if LLVM < 3.5 and the same for get_(s

Re: [Mesa-dev] [PATCH 02/16] radeonsi: Initial geometry shader support

2014-01-27 Thread Marek Olšák
On Sat, Jan 25, 2014 at 2:21 AM, Marek Olšák wrote: > On Fri, Jan 24, 2014 at 10:19 PM, Marek Olšák wrote: >> 1) Do we really have to have so much code inside #if...#endif? Can we >> always compile everything and just not set the pipe_context functions >> if LLVM < 3.5 and the same for get_(shade

Re: [Mesa-dev] [PATCH 02/16] radeonsi: Initial geometry shader support

2014-01-24 Thread Marek Olšák
On Fri, Jan 24, 2014 at 10:19 PM, Marek Olšák wrote: > 1) Do we really have to have so much code inside #if...#endif? Can we > always compile everything and just not set the pipe_context functions > if LLVM < 3.5 and the same for get_(shader_)param? You can even do it > without the preprocessor, e