On Sat, Nov 14, 2015 at 9:30 AM, Jason Ekstrand wrote:
> On Sat, Nov 14, 2015 at 9:25 AM, Connor Abbott wrote:
>> On Sat, Nov 14, 2015 at 11:55 AM, Rob Clark wrote:
>>> well, clone just needs to know the number of elements, so this is the
>>> simplest possible solution.. not against tracking the
On Sat, Nov 14, 2015 at 9:25 AM, Connor Abbott wrote:
> On Sat, Nov 14, 2015 at 11:55 AM, Rob Clark wrote:
>> well, clone just needs to know the number of elements, so this is the
>> simplest possible solution.. not against tracking the type as well, if
>> that is needed elsewhere.. or if there w
On Sat, Nov 14, 2015 at 11:55 AM, Rob Clark wrote:
> well, clone just needs to know the number of elements, so this is the
> simplest possible solution.. not against tracking the type as well, if
> that is needed elsewhere.. or if there was a helper to map type to #
> of elements, I suppose, but f
On Sat, Nov 14, 2015 at 11:55 AM, Jason Ekstrand wrote:
> On Sat, Nov 14, 2015 at 8:19 AM, Connor Abbott wrote:
>> I think it would be better if we kept track of the type of the
>> constant instead. That would also allow us to simplify the constant
>> construction code in, err, something else...
well, clone just needs to know the number of elements, so this is the
simplest possible solution.. not against tracking the type as well, if
that is needed elsewhere.. or if there was a helper to map type to #
of elements, I suppose, but for now this makes clone possible.
BR,
-R
On Sat, Nov 14, 2
On Sat, Nov 14, 2015 at 8:19 AM, Connor Abbott wrote:
> I think it would be better if we kept track of the type of the
> constant instead. That would also allow us to simplify the constant
> construction code in, err, something else...
We do keep track of the type. It's in the variable. Do you
I think it would be better if we kept track of the type of the
constant instead. That would also allow us to simplify the constant
construction code in, err, something else...
On Wed, Nov 11, 2015 at 8:23 PM, Jason Ekstrand wrote:
> From: Rob Clark
>
> This will simplify things somewhat in clone
From: Rob Clark
This will simplify things somewhat in clone.
Signed-off-by: Rob Clark
Reviewed-by: Jason Ekstrand
---
src/glsl/nir/glsl_to_nir.cpp | 5 +
src/glsl/nir/nir.h | 5 +
2 files changed, 10 insertions(+)
diff --git a/src/glsl/nir/glsl_to_nir.cpp b/src/glsl/nir/gls
