Re: [Mesa-dev] [PATCH 01/47] nir: rewrite nir_foreach_block and friends

2016-04-14 Thread Jason Ekstrand
Adding the list back in... On Thu, Apr 14, 2016 at 6:05 PM, Jason Ekstrand wrote: > > > On Thu, Apr 14, 2016 at 5:52 PM, Rob Clark wrote: > >> On Thu, Apr 14, 2016 at 7:23 PM, Jason Ekstrand >> wrote: >> > >> > On Apr 14, 2016 4:15 PM, "Connor Abbott" wrote: >> >> >> >> On Wed, Apr 13, 2016 a

Re: [Mesa-dev] [PATCH 01/47] nir: rewrite nir_foreach_block and friends

2016-04-14 Thread Jason Ekstrand
On Apr 12, 2016 9:36 PM, "Connor Abbott" wrote: > > Previously, these were functions which took a callback. This meant that > the per-block code had to be in a separate function, and all the data > that you wanted to pass in had to be a single void *. They walked the > control flow tree recursivel

Re: [Mesa-dev] [PATCH 01/47] nir: rewrite nir_foreach_block and friends

2016-04-14 Thread Jason Ekstrand
On Apr 14, 2016 4:15 PM, "Connor Abbott" wrote: > > On Wed, Apr 13, 2016 at 7:45 PM, Jason Ekstrand wrote: > > > > > > On Wed, Apr 13, 2016 at 2:06 PM, Connor Abbott wrote: > >> > >> On Wed, Apr 13, 2016 at 3:20 PM, Jason Ekstrand > >> wrote: > >> > > >> > > >> > On Wed, Apr 13, 2016 at 12:15 P

Re: [Mesa-dev] [PATCH 01/47] nir: rewrite nir_foreach_block and friends

2016-04-14 Thread Connor Abbott
On Wed, Apr 13, 2016 at 7:45 PM, Jason Ekstrand wrote: > > > On Wed, Apr 13, 2016 at 2:06 PM, Connor Abbott wrote: >> >> On Wed, Apr 13, 2016 at 3:20 PM, Jason Ekstrand >> wrote: >> > >> > >> > On Wed, Apr 13, 2016 at 12:15 PM, Connor Abbott >> > wrote: >> >> >> >> On Wed, Apr 13, 2016 at 2:49

Re: [Mesa-dev] [PATCH 01/47] nir: rewrite nir_foreach_block and friends

2016-04-13 Thread Jason Ekstrand
On Wed, Apr 13, 2016 at 2:06 PM, Connor Abbott wrote: > On Wed, Apr 13, 2016 at 3:20 PM, Jason Ekstrand > wrote: > > > > > > On Wed, Apr 13, 2016 at 12:15 PM, Connor Abbott > wrote: > >> > >> On Wed, Apr 13, 2016 at 2:49 PM, Jason Ekstrand > >> wrote: > >> > > >> > > >> > On Wed, Apr 13, 2016

Re: [Mesa-dev] [PATCH 01/47] nir: rewrite nir_foreach_block and friends

2016-04-13 Thread Dylan Baker
Quoting Connor Abbott [sni] > > Well, I could make the change, but at this point it would be a bit > more involved. I'd have to figure out how to get the list of files > changed with each commit and then run a sed job on only them > (otherwise I'd re-swap the arguments for everything else), and th

Re: [Mesa-dev] [PATCH 01/47] nir: rewrite nir_foreach_block and friends

2016-04-13 Thread Connor Abbott
On Wed, Apr 13, 2016 at 3:20 PM, Jason Ekstrand wrote: > > > On Wed, Apr 13, 2016 at 12:15 PM, Connor Abbott wrote: >> >> On Wed, Apr 13, 2016 at 2:49 PM, Jason Ekstrand >> wrote: >> > >> > >> > On Wed, Apr 13, 2016 at 8:15 AM, Jason Ekstrand >> > wrote: >> >> >> >> >> >> On Apr 13, 2016 4:57 A

Re: [Mesa-dev] [PATCH 01/47] nir: rewrite nir_foreach_block and friends

2016-04-13 Thread Jason Ekstrand
On Wed, Apr 13, 2016 at 12:15 PM, Connor Abbott wrote: > On Wed, Apr 13, 2016 at 2:49 PM, Jason Ekstrand > wrote: > > > > > > On Wed, Apr 13, 2016 at 8:15 AM, Jason Ekstrand > > wrote: > >> > >> > >> On Apr 13, 2016 4:57 AM, "Rob Clark" wrote: > >> > > >> > On Wed, Apr 13, 2016 at 12:34 AM, Co

Re: [Mesa-dev] [PATCH 01/47] nir: rewrite nir_foreach_block and friends

2016-04-13 Thread Connor Abbott
On Wed, Apr 13, 2016 at 2:49 PM, Jason Ekstrand wrote: > > > On Wed, Apr 13, 2016 at 8:15 AM, Jason Ekstrand > wrote: >> >> >> On Apr 13, 2016 4:57 AM, "Rob Clark" wrote: >> > >> > On Wed, Apr 13, 2016 at 12:34 AM, Connor Abbott >> > wrote: >> > > Previously, these were functions which took a c

Re: [Mesa-dev] [PATCH 01/47] nir: rewrite nir_foreach_block and friends

2016-04-13 Thread Connor Abbott
On Wed, Apr 13, 2016 at 11:15 AM, Jason Ekstrand wrote: > > On Apr 13, 2016 4:57 AM, "Rob Clark" wrote: >> [...] >> >> so, I like the new iterator macros, but this is one giant massive >> unbisectable flag-day change :-( >> >> I'd prefer an approach that kept the old fxns implemented in terms of

Re: [Mesa-dev] [PATCH 01/47] nir: rewrite nir_foreach_block and friends

2016-04-13 Thread Jason Ekstrand
On Wed, Apr 13, 2016 at 8:15 AM, Jason Ekstrand wrote: > > On Apr 13, 2016 4:57 AM, "Rob Clark" wrote: > > > > On Wed, Apr 13, 2016 at 12:34 AM, Connor Abbott > wrote: > > > Previously, these were functions which took a callback. This meant that > > > the per-block code had to be in a separate

Re: [Mesa-dev] [PATCH 01/47] nir: rewrite nir_foreach_block and friends

2016-04-13 Thread Jason Ekstrand
On Apr 13, 2016 4:57 AM, "Rob Clark" wrote: > > On Wed, Apr 13, 2016 at 12:34 AM, Connor Abbott wrote: > > Previously, these were functions which took a callback. This meant that > > the per-block code had to be in a separate function, and all the data > > that you wanted to pass in had to be a s

Re: [Mesa-dev] [PATCH 01/47] nir: rewrite nir_foreach_block and friends

2016-04-13 Thread Rob Clark
On Wed, Apr 13, 2016 at 12:34 AM, Connor Abbott wrote: > Previously, these were functions which took a callback. This meant that > the per-block code had to be in a separate function, and all the data > that you wanted to pass in had to be a single void *. They walked the > control flow tree recur

[Mesa-dev] [PATCH 01/47] nir: rewrite nir_foreach_block and friends

2016-04-12 Thread Connor Abbott
Previously, these were functions which took a callback. This meant that the per-block code had to be in a separate function, and all the data that you wanted to pass in had to be a single void *. They walked the control flow tree recursively, doing a depth-first search, and called the callback in a