Re: [Mesa-dev] [PATCH 01/37] mesa: add gl_texture_image::Face, Level fields

2011-08-15 Thread Brian Paul
On Mon, Aug 15, 2011 at 3:43 PM, Ian Romanick wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > This series is huge, so I'm going to review it in batches.  I've > reviewed 01/37 through 10/37, inclusive.  I'm sending replies with > comments to 01/37 and 05/37.  The rest look good and ge

Re: [Mesa-dev] [PATCH 01/37] mesa: add gl_texture_image::Face, Level fields

2011-08-15 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 This series is huge, so I'm going to review it in batches. I've reviewed 01/37 through 10/37, inclusive. I'm sending replies with comments to 01/37 and 05/37. The rest look good and get my R-b. On 08/15/2011 11:53 AM, Eric Anholt wrote: > From: Bri

[Mesa-dev] [PATCH 01/37] mesa: add gl_texture_image::Face, Level fields

2011-08-15 Thread Eric Anholt
From: Brian Paul Several drivers have these fields in their subclasses of gl_texture_image. They'll be useful for core Mesa too... --- src/mesa/main/mtypes.h |2 ++ src/mesa/main/teximage.c |2 ++ 2 files changed, 4 insertions(+), 0 deletions(-) diff --git a/src/mesa/main/mtypes.h b/s