Re: [Mesa-dev] [PATCH 01/20] mesa: fix and simplify resource query for arrays

2015-08-01 Thread Timothy Arceri
On Sat, 2015-08-01 at 15:58 -0700, Matt Turner wrote: > On Wed, Jul 29, 2015 at 6:56 AM, Timothy Arceri > wrote: > > This removes the need for multiple functions designed to validate an array > > subscript and replaces them with a call to a single function. > > > > The change also means that val

Re: [Mesa-dev] [PATCH 01/20] mesa: fix and simplify resource query for arrays

2015-08-01 Thread Matt Turner
On Wed, Jul 29, 2015 at 6:56 AM, Timothy Arceri wrote: > This removes the need for multiple functions designed to validate an array > subscript and replaces them with a call to a single function. > > The change also means that validation is now only done once and the index > is retrived at the sam

Re: [Mesa-dev] [PATCH 01/20] mesa: fix and simplify resource query for arrays

2015-07-30 Thread Timothy Arceri
On Thu, 2015-07-30 at 14:21 +0300, Tapani Pälli wrote: > On 07/30/2015 12:26 PM, Timothy Arceri wrote: > > On Thu, 2015-07-30 at 11:07 +0300, Tapani Pälli wrote: > > > On 07/30/2015 08:56 AM, Tapani Pälli wrote: > > > > On 07/30/2015 08:50 AM, Timothy Arceri wrote: > > > > > On 30 July 2015 3:27:41

Re: [Mesa-dev] [PATCH 01/20] mesa: fix and simplify resource query for arrays

2015-07-30 Thread Tapani Pälli
On 07/30/2015 12:26 PM, Timothy Arceri wrote: On Thu, 2015-07-30 at 11:07 +0300, Tapani Pälli wrote: On 07/30/2015 08:56 AM, Tapani Pälli wrote: On 07/30/2015 08:50 AM, Timothy Arceri wrote: On 30 July 2015 3:27:41 pm AEST, "Tapani Pälli" wrote: On 07/30/2015 08:25 AM, Tapani Pälli wrote: H

Re: [Mesa-dev] [PATCH 01/20] mesa: fix and simplify resource query for arrays

2015-07-30 Thread Timothy Arceri
On Thu, 2015-07-30 at 11:07 +0300, Tapani Pälli wrote: > On 07/30/2015 08:56 AM, Tapani Pälli wrote: > > On 07/30/2015 08:50 AM, Timothy Arceri wrote: > > > > > > On 30 July 2015 3:27:41 pm AEST, "Tapani Pälli" > > > wrote: > > > > On 07/30/2015 08:25 AM, Tapani Pälli wrote: > > > > > Hi Timothy

Re: [Mesa-dev] [PATCH 01/20] mesa: fix and simplify resource query for arrays

2015-07-30 Thread Tapani Pälli
On 07/30/2015 08:56 AM, Tapani Pälli wrote: On 07/30/2015 08:50 AM, Timothy Arceri wrote: On 30 July 2015 3:27:41 pm AEST, "Tapani Pälli" wrote: On 07/30/2015 08:25 AM, Tapani Pälli wrote: Hi Timothy; Would it be OK for you to wait a bit with these 3 first patches? I'm currently going thro

Re: [Mesa-dev] [PATCH 01/20] mesa: fix and simplify resource query for arrays

2015-07-29 Thread Tapani Pälli
On 07/30/2015 08:50 AM, Timothy Arceri wrote: On 30 July 2015 3:27:41 pm AEST, "Tapani Pälli" wrote: On 07/30/2015 08:25 AM, Tapani Pälli wrote: Hi Timothy; Would it be OK for you to wait a bit with these 3 first patches? I'm currently going through failing PIQ tests and I have a 1 line fix

Re: [Mesa-dev] [PATCH 01/20] mesa: fix and simplify resource query for arrays

2015-07-29 Thread Timothy Arceri
On 30 July 2015 3:27:41 pm AEST, "Tapani Pälli" wrote: >On 07/30/2015 08:25 AM, Tapani Pälli wrote: >> Hi Timothy; >> >> Would it be OK for you to wait a bit with these 3 first patches? I'm >> currently going through failing PIQ tests and I have a 1 line fix to >> valid_program_resource_index_

Re: [Mesa-dev] [PATCH 01/20] mesa: fix and simplify resource query for arrays

2015-07-29 Thread Tapani Pälli
On 07/30/2015 08:25 AM, Tapani Pälli wrote: Hi Timothy; Would it be OK for you to wait a bit with these 3 first patches? I'm currently going through failing PIQ tests and I have a 1 line fix to valid_program_resource_index_name() that together with your patch "glsl: set stage flag for structs

Re: [Mesa-dev] [PATCH 01/20] mesa: fix and simplify resource query for arrays

2015-07-29 Thread Tapani Pälli
Hi Timothy; Would it be OK for you to wait a bit with these 3 first patches? I'm currently going through failing PIQ tests and I have a 1 line fix to valid_program_resource_index_name() that together with your patch "glsl: set stage flag for structs and arrays in resource list" will fix all of

[Mesa-dev] [PATCH 01/20] mesa: fix and simplify resource query for arrays

2015-07-29 Thread Timothy Arceri
This removes the need for multiple functions designed to validate an array subscript and replaces them with a call to a single function. The change also means that validation is now only done once and the index is retrived at the same time, as a result the getUniformLocation code can be simplified