Re: [Mesa-dev] [PATCH 01/17] gallium: Add PIPE_CAP_MSAA_MODES

2016-03-21 Thread eocallaghan
On 2016-03-21 21:06, Marek Olšák wrote: On Sat, Mar 19, 2016 at 5:09 PM, Ilia Mirkin wrote: On Sat, Mar 19, 2016 at 12:02 PM, Bas Nieuwenhuizen wrote: On Sat, Mar 19, 2016 at 4:25 PM, Ilia Mirkin wrote: On Sat, Mar 19, 2016 at 11:14 AM, Bas Nieuwenhuizen wrote: That would limit us to supp

Re: [Mesa-dev] [PATCH 01/17] gallium: Add PIPE_CAP_MSAA_MODES

2016-03-21 Thread Marek Olšák
On Sat, Mar 19, 2016 at 5:09 PM, Ilia Mirkin wrote: > On Sat, Mar 19, 2016 at 12:02 PM, Bas Nieuwenhuizen > wrote: >> On Sat, Mar 19, 2016 at 4:25 PM, Ilia Mirkin wrote: >>> On Sat, Mar 19, 2016 at 11:14 AM, Bas Nieuwenhuizen >>> wrote: That would limit us to supporting sample counts for w

Re: [Mesa-dev] [PATCH 01/17] gallium: Add PIPE_CAP_MSAA_MODES

2016-03-19 Thread Ilia Mirkin
On Sat, Mar 19, 2016 at 12:02 PM, Bas Nieuwenhuizen wrote: > On Sat, Mar 19, 2016 at 4:25 PM, Ilia Mirkin wrote: >> On Sat, Mar 19, 2016 at 11:14 AM, Bas Nieuwenhuizen >> wrote: >>> That would limit us to supporting sample counts for which we have >>> texture formats. >>> >>> As far as I underst

Re: [Mesa-dev] [PATCH 01/17] gallium: Add PIPE_CAP_MSAA_MODES

2016-03-19 Thread Bas Nieuwenhuizen
On Sat, Mar 19, 2016 at 4:25 PM, Ilia Mirkin wrote: > On Sat, Mar 19, 2016 at 11:14 AM, Bas Nieuwenhuizen > wrote: >> That would limit us to supporting sample counts for which we have >> texture formats. >> >> As far as I understand with radeonsi we can support 16 samples without >> any attachmen

Re: [Mesa-dev] [PATCH 01/17] gallium: Add PIPE_CAP_MSAA_MODES

2016-03-19 Thread Ilia Mirkin
On Sat, Mar 19, 2016 at 11:14 AM, Bas Nieuwenhuizen wrote: > That would limit us to supporting sample counts for which we have > texture formats. > > As far as I understand with radeonsi we can support 16 samples without > any attachments, but all formats are limited to <= 8 samples. So you're go

Re: [Mesa-dev] [PATCH 01/17] gallium: Add PIPE_CAP_MSAA_MODES

2016-03-19 Thread Bas Nieuwenhuizen
That would limit us to supporting sample counts for which we have texture formats. As far as I understand with radeonsi we can support 16 samples without any attachments, but all formats are limited to <= 8 samples. - Bas On Sat, Mar 19, 2016 at 3:00 PM, Ilia Mirkin wrote: > Why not derive this

Re: [Mesa-dev] [PATCH 01/17] gallium: Add PIPE_CAP_MSAA_MODES

2016-03-19 Thread Ilia Mirkin
Why not derive this information from is_format_supported with rgba8 format? Seems like that would do the trick. Look at how the st already does something similar in st_extensions.c iirc. Your scheme only enables power-of-two msaa levels, and is redundant wrt the function I mentioned earlier... As

[Mesa-dev] [PATCH 01/17] gallium: Add PIPE_CAP_MSAA_MODES

2016-03-18 Thread Edward O'Callaghan
Add PIPE_CAP to determine the MSAA modes the hardware supports so that values requested from the application using GL_ARB_framebuffer_no_attachments may be quantized to what the hardware expects. V.2: Fix doc for a more detailed description of the PIPE_CAP and the corresponding GL constant. Sig