Re: [Mesa-dev] [PATCH 01/15] glsl: Avoid GLboolean vs bool arithmetic MSVC warnings.

2015-03-20 Thread Ian Romanick
This patch is Reviewed-by: Ian Romanick On 03/20/2015 06:59 AM, Jose Fonseca wrote: > Note that GLboolean is an alias for unsigned char, which lacks the > implicit true/false semantics that C++/C99 bool have. > > Reviewed-by: Brian Paul > > v2: Change gl_shader::IsES and gl_shader_program::Is

[Mesa-dev] [PATCH 01/15] glsl: Avoid GLboolean vs bool arithmetic MSVC warnings.

2015-03-20 Thread Jose Fonseca
Note that GLboolean is an alias for unsigned char, which lacks the implicit true/false semantics that C++/C99 bool have. Reviewed-by: Brian Paul v2: Change gl_shader::IsES and gl_shader_program::IsES to be bool as recommended by Ian Romanick. --- src/glsl/linker.cpp| 5 +++-- src/mesa/main/