Re: [Mesa-dev] [PATCH 01/13] vbo: Declare the index range invalid for DrawIndirect

2016-05-22 Thread Michael Schellenberger Costa
Hi Jason, Am 19.05.2016 um 09:20 schrieb Jason Ekstrand: > Right now, we're just setting the range to [0, MAX_UINT32] which, while > correct isn't helpful. With DrawIndirect, you can't really know what the > actual range is so we may as well flag it as being an invalid range. This > is what we d

Re: [Mesa-dev] [PATCH 01/13] vbo: Declare the index range invalid for DrawIndirect

2016-05-19 Thread Kenneth Graunke
On Thursday, May 19, 2016 12:20:58 AM PDT Jason Ekstrand wrote: > Right now, we're just setting the range to [0, MAX_UINT32] which, while > correct isn't helpful. With DrawIndirect, you can't really know what the > actual range is so we may as well flag it as being an invalid range. This > is wha

Re: [Mesa-dev] [PATCH 01/13] vbo: Declare the index range invalid for DrawIndirect

2016-05-19 Thread Ian Romanick
On 05/19/2016 12:20 AM, Jason Ekstrand wrote: > Right now, we're just setting the range to [0, MAX_UINT32] which, while > correct isn't helpful. With DrawIndirect, you can't really know what the > actual range is so we may as well flag it as being an invalid range. This > is what we do for draws

Re: [Mesa-dev] [PATCH 01/13] vbo: Declare the index range invalid for DrawIndirect

2016-05-19 Thread Iago Toral
I left a minor comment in patch 4, but other than that patches 1-4 are: Reviewed-by: Iago Toral Quiroga On Thu, 2016-05-19 at 00:20 -0700, Jason Ekstrand wrote: > Right now, we're just setting the range to [0, MAX_UINT32] which, while > correct isn't helpful. With DrawIndirect, you can't really

Re: [Mesa-dev] [PATCH 01/13] vbo: Declare the index range invalid for DrawIndirect

2016-05-19 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Thu, May 19, 2016 at 9:20 AM, Jason Ekstrand wrote: > Right now, we're just setting the range to [0, MAX_UINT32] which, while > correct isn't helpful. With DrawIndirect, you can't really know what the > actual range is so we may as well flag it as being an inv

[Mesa-dev] [PATCH 01/13] vbo: Declare the index range invalid for DrawIndirect

2016-05-19 Thread Jason Ekstrand
Right now, we're just setting the range to [0, MAX_UINT32] which, while correct isn't helpful. With DrawIndirect, you can't really know what the actual range is so we may as well flag it as being an invalid range. This is what we do for draws with index buffer which is similar (the indices aren't