Re: [Mesa-dev] [PATCH 01/12] nir: Get rid of function overloads

2015-12-28 Thread Rob Clark
On Sat, Dec 26, 2015 at 2:09 PM, Jason Ekstrand wrote: > When Connor originally drafted NIR, he copied the same function+overload > system that GLSL IR had with a few names changed. However, this > double-indirection is not really needed and has only served to confuse > people. Instead, let's ju

Re: [Mesa-dev] [PATCH 01/12] nir: Get rid of function overloads

2015-12-26 Thread Kenneth Graunke
On Saturday, December 26, 2015 11:09:24 AM PST Jason Ekstrand wrote: > When Connor originally drafted NIR, he copied the same function+overload > system that GLSL IR had with a few names changed. However, this > double-indirection is not really needed and has only served to confuse > people. Inst

Re: [Mesa-dev] [PATCH 01/12] nir: Get rid of function overloads

2015-12-26 Thread Connor Abbott
Reviewed-by: Connor Abbott On Sat, Dec 26, 2015 at 2:09 PM, Jason Ekstrand wrote: > When Connor originally drafted NIR, he copied the same function+overload > system that GLSL IR had with a few names changed. However, this > double-indirection is not really needed and has only served to confuse

[Mesa-dev] [PATCH 01/12] nir: Get rid of function overloads

2015-12-26 Thread Jason Ekstrand
When Connor originally drafted NIR, he copied the same function+overload system that GLSL IR had with a few names changed. However, this double-indirection is not really needed and has only served to confuse people. Instead, let's just have functions which may not have unique names and may or may