On 01/17/2018 09:39 AM, Brian Paul wrote:
> On 01/17/2018 10:08 AM, Ian Romanick wrote:
>> Should probably also change the assert(0) to unreachable(). It's
>> possible that will help the compiler generate slightly better code in
>> release builds.
>
> There's a bunch of assert(0) calls in the VBO
On 01/17/2018 10:08 AM, Ian Romanick wrote:
Should probably also change the assert(0) to unreachable(). It's
possible that will help the compiler generate slightly better code in
release builds.
There's a bunch of assert(0) calls in the VBO code. How about I take
care of those in a separate
On 01/17/2018 07:20 AM, Emil Velikov wrote:
On 17 January 2018 at 05:17, Brian Paul wrote:
Both switch cases began with the same code.
Might even go a step further refactoring the common bits (say ~90%) of
the two functions into a helper.
One step at a time though - patch is a good start.
Ye
I sent one other tiny nit on patch 7. With or without that, the series is
Reviewed-by: Ian Romanick
On 01/17/2018 09:08 AM, Ian Romanick wrote:
> Should probably also change the assert(0) to unreachable(). It's
> possible that will help the compiler generate slightly better code in
> release b
Should probably also change the assert(0) to unreachable(). It's
possible that will help the compiler generate slightly better code in
release builds.
On 01/16/2018 09:17 PM, Brian Paul wrote:
> Both switch cases began with the same code.
> ---
> src/mesa/vbo/vbo_exec_draw.c | 15 ++-
On 17 January 2018 at 05:17, Brian Paul wrote:
> Both switch cases began with the same code.
Might even go a step further refactoring the common bits (say ~90%) of
the two functions into a helper.
One step at a time though - patch is a good start.
Reviewed-by: Emil Velikov
-Emil
Both switch cases began with the same code.
---
src/mesa/vbo/vbo_exec_draw.c | 15 ++-
src/mesa/vbo/vbo_save_draw.c | 15 ++-
2 files changed, 12 insertions(+), 18 deletions(-)
diff --git a/src/mesa/vbo/vbo_exec_draw.c b/src/mesa/vbo/vbo_exec_draw.c
index 34cb4ff..de17322
