Re: [Mesa-dev] [PATCH 01/10] glsl/linker: Silence unused parameter warning

2016-05-20 Thread Timothy Arceri
Patches 1-3, 4 (with comments addressed), 6-10 are: Reviewed-by: Timothy Arceri I've made a comment on Patch 5, its also a shame we need to loop over the entire NumProgramResourceList. If you are not concern about performance at this stage then you can add my r-b there too. 

Re: [Mesa-dev] [PATCH 01/10] glsl/linker: Silence unused parameter warning

2016-05-20 Thread Alejandro Piñeiro
Series lgtm. Just sent a nitpick for patch 05, feel free to ignore it. Series is: Reviewed-by: Alejandro Piñeiro On 20/05/16 09:25, Ian Romanick wrote: > From: Ian Romanick > > The parameter is required for the interface. > > glsl/link_uniforms.cpp:689:61: warning: unused parameter ‘record_type

[Mesa-dev] [PATCH 01/10] glsl/linker: Silence unused parameter warning

2016-05-20 Thread Ian Romanick
From: Ian Romanick The parameter is required for the interface. glsl/link_uniforms.cpp:689:61: warning: unused parameter ‘record_type’ [-Wunused-parameter] bool row_major, const glsl_type *record_type, ^