Re: [Mesa-dev] [PATCH 007/133] nir: add a validation pass

2014-12-19 Thread Eric Anholt
Connor Abbott writes: > On Thu, Dec 18, 2014 at 1:49 PM, Eric Anholt wrote: >> Connor Abbott writes: >> >>> On Thu, Dec 18, 2014 at 2:01 AM, Eric Anholt wrote: Jason Ekstrand writes: > From: Connor Abbott > > This is similar to ir_validate.cpp. > > v2: Jason Eks

Re: [Mesa-dev] [PATCH 007/133] nir: add a validation pass

2014-12-18 Thread Connor Abbott
On Thu, Dec 18, 2014 at 1:49 PM, Eric Anholt wrote: > Connor Abbott writes: > >> On Thu, Dec 18, 2014 at 2:01 AM, Eric Anholt wrote: >>> Jason Ekstrand writes: >>> From: Connor Abbott This is similar to ir_validate.cpp. v2: Jason Ekstrand : whitespace fixes >>>

Re: [Mesa-dev] [PATCH 007/133] nir: add a validation pass

2014-12-18 Thread Eric Anholt
Connor Abbott writes: > On Thu, Dec 18, 2014 at 2:01 AM, Eric Anholt wrote: >> Jason Ekstrand writes: >> >>> From: Connor Abbott >>> >>> This is similar to ir_validate.cpp. >>> >>> v2: Jason Ekstrand : >>>whitespace fixes >> >> I have again not reviewed the control flow bits. Couple of qu

Re: [Mesa-dev] [PATCH 007/133] nir: add a validation pass

2014-12-18 Thread Connor Abbott
On Thu, Dec 18, 2014 at 2:01 AM, Eric Anholt wrote: > Jason Ekstrand writes: > >> From: Connor Abbott >> >> This is similar to ir_validate.cpp. >> >> v2: Jason Ekstrand : >>whitespace fixes > > I have again not reviewed the control flow bits. Couple of questions I > had, though: > >> +stati

Re: [Mesa-dev] [PATCH 007/133] nir: add a validation pass

2014-12-17 Thread Eric Anholt
Jason Ekstrand writes: > From: Connor Abbott > > This is similar to ir_validate.cpp. > > v2: Jason Ekstrand : >whitespace fixes I have again not reviewed the control flow bits. Couple of questions I had, though: > +static void > +validate_var_use(nir_variable *var, validate_state *state)

[Mesa-dev] [PATCH 007/133] nir: add a validation pass

2014-12-15 Thread Jason Ekstrand
From: Connor Abbott This is similar to ir_validate.cpp. v2: Jason Ekstrand : whitespace fixes --- src/glsl/Makefile.sources | 1 + src/glsl/nir/nir.h | 2 + src/glsl/nir/nir_validate.c | 798 3 files changed, 801 insertions(+) crea