Re: [Mesa-dev] [PATCH 004/133] nir: add the core datastructures

2014-12-19 Thread Jason Ekstrand
Glenn, Thanks for taking the time to look over things. On Fri, Dec 19, 2014 at 1:24 PM, Glenn Kennard wrote: > > On Tue, 16 Dec 2014 07:04:14 +0100, Jason Ekstrand > wrote: > > From: Connor Abbott >> >> This includes all the instructions, ifs, loops, functions, etc. This is >> similar to the i

Re: [Mesa-dev] [PATCH 004/133] nir: add the core datastructures

2014-12-19 Thread Glenn Kennard
On Tue, 16 Dec 2014 07:04:14 +0100, Jason Ekstrand wrote: From: Connor Abbott This includes all the instructions, ifs, loops, functions, etc. This is similar to the information in ir.h. v2: Jason Ekstrand : Include ralloc and hash_table from the util directory --- src/glsl/Makefile.sou

Re: [Mesa-dev] [PATCH 004/133] nir: add the core datastructures

2014-12-17 Thread Eric Anholt
Connor Abbott writes: > On Tue, Dec 16, 2014 at 5:48 PM, Eric Anholt wrote: >> Jason Ekstrand writes: >>> +typedef struct { >>> + nir_register *reg; >>> + struct nir_src *indirect; /** < NULL for no indirect offset */ >>> + unsigned base_offset; >>> + >>> + /* TODO def-use chain goes he

Re: [Mesa-dev] [PATCH 004/133] nir: add the core datastructures

2014-12-16 Thread Connor Abbott
On Tue, Dec 16, 2014 at 5:48 PM, Eric Anholt wrote: > Jason Ekstrand writes: > >> From: Connor Abbott >> >> This includes all the instructions, ifs, loops, functions, etc. This is >> similar to the information in ir.h. >> >> v2: Jason Ekstrand : >>Include ralloc and hash_table from the util

Re: [Mesa-dev] [PATCH 004/133] nir: add the core datastructures

2014-12-16 Thread Eric Anholt
Jason Ekstrand writes: > From: Connor Abbott > > This includes all the instructions, ifs, loops, functions, etc. This is > similar to the information in ir.h. > > v2: Jason Ekstrand : >Include ralloc and hash_table from the util directory Just some comment comments. I've been happy with NI

[Mesa-dev] [PATCH 004/133] nir: add the core datastructures

2014-12-15 Thread Jason Ekstrand
From: Connor Abbott This includes all the instructions, ifs, loops, functions, etc. This is similar to the information in ir.h. v2: Jason Ekstrand : Include ralloc and hash_table from the util directory --- src/glsl/Makefile.sources |2 + src/glsl/nir/nir.h| 1150