Re: [Mesa-dev] [PATCH 00/56] Die copy-and-paste code, die

2016-07-22 Thread Rob Clark
On Tue, Jul 19, 2016 at 3:24 PM, Ian Romanick wrote: > After seeing Dave's series to add support GL_ARB_shader_gpu_int64 and > thinking about adding support for 8- and 16-bit integers, I decided > that something had to be done about the cut-and-paste madness that is > ir_constant_expression.cpp.

Re: [Mesa-dev] [PATCH 00/56] Die copy-and-paste code, die

2016-07-22 Thread Dylan Baker
I didn't read over the code super closely, but all of the python looked good and obvious minus a few nits (and they were all just nits). For the python bits: Acked-by: Dylan Baker signature.asc Description: signature ___ mesa-dev mailing list mesa-dev

Re: [Mesa-dev] [PATCH 00/56] Die copy-and-paste code, die

2016-07-20 Thread Matt Turner
On Tue, Jul 19, 2016 at 6:41 PM, Matt Turner wrote: > 1-27 are > > Reviewed-by: Matt Turner Python's not my forte, so I'm going to call the rest of the series weakly Reviewed-by: Matt Turner Dylan may be interested in having a look. ___ mesa-dev mai

Re: [Mesa-dev] [PATCH 00/56] Die copy-and-paste code, die

2016-07-19 Thread Matt Turner
1-27 are Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 00/56] Die copy-and-paste code, die

2016-07-19 Thread Matt Turner
On Tue, Jul 19, 2016 at 12:24 PM, Ian Romanick wrote: > After seeing Dave's series to add support GL_ARB_shader_gpu_int64 and > thinking about adding support for 8- and 16-bit integers, I decided > that something had to be done about the cut-and-paste madness that is > ir_constant_expression.cpp.

[Mesa-dev] [PATCH 00/56] Die copy-and-paste code, die

2016-07-19 Thread Ian Romanick
After seeing Dave's series to add support GL_ARB_shader_gpu_int64 and thinking about adding support for 8- and 16-bit integers, I decided that something had to be done about the cut-and-paste madness that is ir_constant_expression.cpp. I decided to take a page from Jason's book and generate it fr