Re: [Mesa-dev] [PATCH 00/32] UBOs for OpenGL ES 3.0

2013-01-25 Thread Jordan Justen
23 & 26-31 Reviewed-by: Jordan Justen On Tue, Jan 22, 2013 at 12:51 AM, Ian Romanick wrote: > So here it is. > > This is the last of the UBO instance and array instance rework for the > linker. It's a giant pile of patches, so let me explain what's going > on. > > Previous to this patch series,

Re: [Mesa-dev] [PATCH 00/32] UBOs for OpenGL ES 3.0

2013-01-24 Thread Kenneth Graunke
Patches 1-9, 11-22, and 32 are: Reviewed-by: Kenneth Graunke I haven't read the others yet. No objections, just...haven't gotten to them. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 00/32] UBOs for OpenGL ES 3.0

2013-01-23 Thread Ian Romanick
On 01/22/2013 03:51 AM, Ian Romanick wrote: So here it is. I've just pushed a re-spin of this patch series to the gles3 branch. I have incorporated all of the review comments received so far *except* Paul's question on patch 10, and his NULL initialization suggestion on patch 12. This is

Re: [Mesa-dev] [PATCH 00/32] UBOs for OpenGL ES 3.0

2013-01-23 Thread Carl Worth
Ian Romanick writes: > This is the last of the UBO instance and array instance rework for the > linker. It's a giant pile of patches, so let me explain what's going > on. Hi Ian, I just read through what I could of the patch series. You'll see that I emailed out some tiny nit-picky things about

[Mesa-dev] [PATCH 00/32] UBOs for OpenGL ES 3.0

2013-01-22 Thread Ian Romanick
So here it is. This is the last of the UBO instance and array instance rework for the linker. It's a giant pile of patches, so let me explain what's going on. Previous to this patch series, information about the layout of a UBO was created at compile-time during ast-to-ir translation. This made