Re: [Mesa-dev] [PATCH 00/21] intel/compiler: Rework the world of push/pull params

2017-10-12 Thread Kenneth Graunke
On Friday, October 6, 2017 10:27:02 AM PDT Jordan Justen wrote: > Series Reviewed-by: Jordan Justen > > Although, I think you said you might rewrite patch 13 (the > thread_local_id_index patch). If you just add the small stage check I > mentioned then you can add my r-b for it. > > -Jordan Seri

Re: [Mesa-dev] [PATCH 00/21] intel/compiler: Rework the world of push/pull params

2017-10-06 Thread Jordan Justen
Series Reviewed-by: Jordan Justen Although, I think you said you might rewrite patch 13 (the thread_local_id_index patch). If you just add the small stage check I mentioned then you can add my r-b for it. -Jordan On 2017-09-29 14:25:00, Jason Ekstrand wrote: > This little series reworks basical

[Mesa-dev] [PATCH 00/21] intel/compiler: Rework the world of push/pull params

2017-09-29 Thread Jason Ekstrand
This little series reworks basically the entire world of push/pull params. This refactor has been on my ToDo list ever since I hooked up push constants in Vulkan over two years ago. Recently, thanks to some up-and-coming Vulkan features, the pain of the old system increased enough to finally push