Re: [Mesa-dev] [PATCH 00/18] anv: Remove the HiZ restriction on input attachments

2017-02-28 Thread Nanley Chery
On Mon, Feb 27, 2017 at 09:36:53PM -0800, Jason Ekstrand wrote: > Did a read-through and, overall, this looks great. I made a few comments > but they're fairly simple. Thank you for taking the time to look over this series. > > One question though: Am I correct in thinking that we are still di

Re: [Mesa-dev] [PATCH 00/18] anv: Remove the HiZ restriction on input attachments

2017-02-27 Thread Jason Ekstrand
Did a read-through and, overall, this looks great. I made a few comments but they're fairly simple. One question though: Am I correct in thinking that we are still disabling HiZ for rendering when the image is in the general layout? I think it should be easy enough to change now but I didn't se

[Mesa-dev] [PATCH 00/18] anv: Remove the HiZ restriction on input attachments

2017-02-27 Thread Nanley Chery
Allow HiZ for input attachment-capable depth/stencil buffers. Do so without requiring sampling operations on such attachments to go through the HiZ buffer. Series sections: * Patch 1: Fix a bug. * Patch 2: Add a new layout to aux_usage function. * Patches 3-6: Refactor. * Patches 7-10: Don't sampl