Re: [Mesa-dev] [PATCH 00/17] Add support for GL_EXT_semaphore

2017-11-03 Thread Andres Rodriguez
On 2017-11-03 05:15 AM, Nicolai Hähnle wrote: Hi Andres, Thank you for doing this. I haven't read the series in detail yet, but I have a bunch of questions and comments. Thanks for all the feedback. I find it very unfortunate to have both fence and semaphore objects in the Gallium inter

Re: [Mesa-dev] [PATCH 00/17] Add support for GL_EXT_semaphore

2017-11-03 Thread Nicolai Hähnle
Hi Andres, Thank you for doing this. I haven't read the series in detail yet, but I have a bunch of questions and comments. I find it very unfortunate to have both fence and semaphore objects in the Gallium interface. The two even become mixed up in the amdgpu winsys. My first thought is tha

Re: [Mesa-dev] [PATCH 00/17] Add support for GL_EXT_semaphore

2017-11-01 Thread Andres Rodriguez
That's actually a pretty good suggestion, as it would help me get my feet wet on piglit changes with something simple. Thanks, Andres On Nov 2, 2017 1:24 AM, "Timothy Arceri" wrote: > On 02/11/17 15:12, Andres Rodriguez wrote: > >> It was tested against steamvr using an opengl vr client (hellov

Re: [Mesa-dev] [PATCH 00/17] Add support for GL_EXT_semaphore

2017-11-01 Thread Timothy Arceri
On 02/11/17 15:12, Andres Rodriguez wrote: It was tested against steamvr using an opengl vr client (hellovr_opengl for simplicity). Hi Andres, Full tests would be great but at the very least we should start with some piglit tests that exercise the error paths. Tim Regards, Andres On 20

Re: [Mesa-dev] [PATCH 00/17] Add support for GL_EXT_semaphore

2017-11-01 Thread Andres Rodriguez
It was tested against steamvr using an opengl vr client (hellovr_opengl for simplicity). Regards, Andres On 2017-11-02 12:07 AM, Jason Ekstrand wrote: Out of curiosity, how has this series been tested beyond regression testing? On November 1, 2017 20:57:57 Andres Rodriguez wrote: This s

Re: [Mesa-dev] [PATCH 00/17] Add support for GL_EXT_semaphore

2017-11-01 Thread Jason Ekstrand
Out of curiosity, how has this series been tested beyond regression testing? On November 1, 2017 20:57:57 Andres Rodriguez wrote: This series adds radeonsi support for GL_EXT_semaphore. GL_EXT_semaphore is used by steam's vrclient to synchronize access to shared surfaces (vulkan <-> gl inter

[Mesa-dev] [PATCH 00/17] Add support for GL_EXT_semaphore

2017-11-01 Thread Andres Rodriguez
This series adds radeonsi support for GL_EXT_semaphore. GL_EXT_semaphore is used by steam's vrclient to synchronize access to shared surfaces (vulkan <-> gl interop). It allows our gl vrclients to enqueue their framebuffer surface without waiting for a glFinish(). If anyone has any suggestions on