Re: [Mesa-dev] [PATCH 00/15] Implement KHR_debug

2013-09-05 Thread Ian Romanick
On 09/04/2013 03:11 PM, Timothy Arceri wrote: >> Since you obviously didn't run 'make check', I will be reverting >> this entire series later today. >> >> YOU MUST RUN 'make check'. > > Ok, well what can I say I didnt know (or I guess didnt check) that > Mesa had a Testsuite I will submit a patc

Re: [Mesa-dev] [PATCH 00/15] Implement KHR_debug

2013-09-04 Thread Timothy Arceri
>Since you obviously didn't run 'make check', I will be reverting this >entire series later today. > >YOU MUST RUN 'make check'. Ok, well what can I say I didnt know (or I guess didnt check) that Mesa had a Testsuite I will submit a patch to add a section to devinfo.html about submitting patch

Re: [Mesa-dev] [PATCH 00/15] Implement KHR_debug

2013-09-04 Thread Ian Romanick
On 09/04/2013 12:28 PM, Brian Paul wrote: > OK, make check passes or fails depending on how you configure. My tree > configured for LLVM/softpipe says make check passes. But in my > DRI/vmware-svga tree, make check fails. Aren't the software pipe drivers DRI? It seems like they should still hit

Re: [Mesa-dev] [PATCH 00/15] Implement KHR_debug

2013-09-04 Thread Brian Paul
OK, make check passes or fails depending on how you configure. My tree configured for LLVM/softpipe says make check passes. But in my DRI/vmware-svga tree, make check fails. I think the fix is pretty simple: add the new GL_KHR_debug functions to dispatch_sanity.cpp. I'll post a patch... -

Re: [Mesa-dev] [PATCH 00/15] Implement KHR_debug

2013-09-04 Thread Brian Paul
I just did a 'make check' here and didn't see any failures. However, my output looks different from what Paul posted. I need to do a fresh reconfigure/test... -Brian On 09/04/2013 12:24 PM, Ian Romanick wrote: Since you obviously didn't run 'make check', I will be reverting this entire ser

Re: [Mesa-dev] [PATCH 00/15] Implement KHR_debug

2013-09-04 Thread Ian Romanick
Since you obviously didn't run 'make check', I will be reverting this entire series later today. YOU MUST RUN 'make check'. On 08/26/2013 03:43 AM, Timothy Arceri wrote: > The following patchset implements the KHR_debug extension. > > Here are some notes/assumptions I have made: > > * These pat

Re: [Mesa-dev] [PATCH 00/15] Implement KHR_debug

2013-08-26 Thread Brian Paul
On 08/26/2013 04:43 AM, Timothy Arceri wrote: The following patchset implements the KHR_debug extension. The series looks good to me. Just a few minor comments to follow. Reviewed-by: Brian Paul ___ mesa-dev mailing list mesa-dev@lists.freedesktop

[Mesa-dev] [PATCH 00/15] Implement KHR_debug

2013-08-26 Thread Timothy Arceri
The following patchset implements the KHR_debug extension. Here are some notes/assumptions I have made: * These patches only enable the extension for GL not ES * MAX_LABEL_LENGTH and MAX_DEBUG_GROUP_STACK_DEPTH are set to the minimum values defined in the spec. * Assume its fine that Push/Pop