Re: [Mesa-dev] [PATCH 00/13] clang warning fixes

2017-08-10 Thread Jordan Justen
Where's the patchlist on your cover letter? :) 1: Reviewed-by: Jordan Justen 2: If only changing the string calls: Reviewed-by: Jordan Justen 3-5: Reviewed-by: Jordan Justen 6-8: Do you have data that removing the inlines doesn't hurt things? ;) I actually don't have an opinion on th

[Mesa-dev] [PATCH 00/13] clang warning fixes

2017-08-10 Thread Matt Turner
Just a simple series cleaning up various bits of code that clang warns about. The only real change is to "i965/vec4: Return float from spill_cost_for_type()" which fixes an obvious mistake. The rest just cleans things up like marking internal functions static. __