Re: [Mesa-dev] [PATCH 00/13] Avoid double promotion

2015-07-15 Thread Matt Turner
On Tue, Jul 14, 2015 at 4:32 AM, Daniel Stone wrote: > Hi, > > On 14 July 2015 at 00:22, Matt Turner wrote: > but it's not really >> useful in general because float arguments are always cast to double >> when passed as arguments to varargs functions like printf (why?), and >> it warns about that,

Re: [Mesa-dev] [PATCH 00/13] Avoid double promotion

2015-07-14 Thread Thomas Helland
Hi Matt, Just a small nitpick I noticed; s/promition/promotion in the commit message. -Thomas 2015-07-14 1:22 GMT+02:00 Matt Turner : > In the process of looking at the assembly generated from the OUT_BATCH > series, I noticed a bunch of float <-> double round trips. Mostly this > arises because

Re: [Mesa-dev] [PATCH 00/13] Avoid double promotion

2015-07-14 Thread Daniel Stone
Hi, On 14 July 2015 at 00:22, Matt Turner wrote: but it's not really > useful in general because float arguments are always cast to double > when passed as arguments to varargs functions like printf (why?), and > it warns about that, generating a lot of noise. It might shock you to learn that th

[Mesa-dev] [PATCH 00/13] Avoid double promotion

2015-07-13 Thread Matt Turner
In the process of looking at the assembly generated from the OUT_BATCH series, I noticed a bunch of float <-> double round trips. Mostly this arises because unsuffixed floating-point literals are of type double, and (float op double) is a double operation in which the float is implicitly converted