On Thu, Jan 28, 2016 at 11:54 PM, Iago Toral wrote:
> Hi Matt,
>
> With the small changes agreed with Jason for patches 9 and 10 you can
> add my Rb to those two patches as well. I think with that the entire
> series is reviewed.
Thanks for all of your reviews!
___
Hi Matt,
With the small changes agreed with Jason for patches 9 and 10 you can
add my Rb to those two patches as well. I think with that the entire
series is reviewed.
I also left a comment in patch 9 about using f2u instead f2i since it
looks like that would be more correct by the spec, but it i
On Tue, Jan 26, 2016 at 10:05 AM, Eric Anholt wrote:
> Matt Turner writes:
>
>> This series adds NIR support for lowering pack/unpack opcodes and
>> switches i965 over to using that. The only place we still use the
>> GLSL IR lower_packing_builtins.cpp is for the half-precision functions
>> on Sa
Matt Turner writes:
> This series adds NIR support for lowering pack/unpack opcodes and
> switches i965 over to using that. The only place we still use the
> GLSL IR lower_packing_builtins.cpp is for the half-precision functions
> on Sandybridge.
>
> As a result, I get to remove the ir_unop_unpac
Patches 1 to 4 are,
Reviewed-by: Iago Toral Quiroga
I intend to review the remaining patches tomorrow as well if nobody else
beats me to it.
Iago
On Mon, 2016-01-25 at 15:18 -0800, Matt Turner wrote:
> This series adds NIR support for lowering pack/unpack opcodes and
> switches i965 over to us
This series adds NIR support for lowering pack/unpack opcodes and
switches i965 over to using that. The only place we still use the
GLSL IR lower_packing_builtins.cpp is for the half-precision functions
on Sandybridge.
As a result, I get to remove the ir_unop_unpack_half_2x16_split_x/y opcodes
fro
