Re: [Mesa-dev] [PATCH 00/10] glsl: Support unsized arrays in interface blocks.

2013-10-09 Thread Paul Berry
On 8 October 2013 23:25, Jordan Justen wrote: > Patches 1, 2 & 4 - 10: > Reviewed-by: Jordan Justen > > For 8, I replied with a non-essential question, and the same question > is relevant in patch 10. > > For patch 3 I had that question (mentioned on irc) about ir having > ast/parser knowledge.

Re: [Mesa-dev] [PATCH 00/10] glsl: Support unsized arrays in interface blocks.

2013-10-09 Thread Jordan Justen
Patches 1, 2 & 4 - 10: Reviewed-by: Jordan Justen For 8, I replied with a non-essential question, and the same question is relevant in patch 10. For patch 3 I had that question (mentioned on irc) about ir having ast/parser knowledge. I guess I'd like to think about this one a little more. -Jord

[Mesa-dev] [PATCH 00/10] glsl: Support unsized arrays in interface blocks.

2013-09-27 Thread Paul Berry
Although it's not explicitly stated in the GLSL 1.50 spec, it is clearly implied that unsized arrays are allowed in interface blocks (the built-in interface gl_PerVertex contains an unsized array, gl_ClipDistance, and examples added in GLSL 4.30 make use of unsized arrays in interface blocks). >Fr