Re: [Mesa-dev] [PATCH 0/9] spirv: Improve logging and error handling

2017-09-04 Thread Tapani Pälli
On 08/29/2017 01:55 PM, Tapani Pälli wrote: LGTM, patches 1-5 Reviewed-by: Tapani Pälli With these changes we can add a nir_spirv_debug_callback that has instance and shader object in private data so that we can call VK_EXT_debug_report functionality from anv_pipeline code. Went throug

Re: [Mesa-dev] [PATCH 0/9] spirv: Improve logging and error handling

2017-08-29 Thread Tapani Pälli
LGTM, patches 1-5 Reviewed-by: Tapani Pälli With these changes we can add a nir_spirv_debug_callback that has instance and shader object in private data so that we can call VK_EXT_debug_report functionality from anv_pipeline code. On 08/17/2017 08:22 PM, Jason Ekstrand wrote: This series

[Mesa-dev] [PATCH 0/9] spirv: Improve logging and error handling

2017-08-17 Thread Jason Ekstrand
This series has two objectives: 1) Improve logging to provide more detail and provide hooks so we can plumb errors and warnings through to debug_report extensions. 2) Improve error handling so that not all errors result in killing the process. This is done by adding new spv_fail and sp