On Tue, Apr 26, 2016 at 10:43 PM, Eduardo Lima Mitev
wrote:
> Patches 1, 4 and 5 need rebasing.
>
No surprises there. Some of these really need Connor's 47-patch series to
happen first.
> Patches 2, 3 and 6 are:
>
> Reviewed-by: Eduardo Lima Mitev
>
Thanks! I'll push what I can.
> Thanks
On Wed, Apr 27, 2016 at 12:52 AM, Ian Romanick wrote:
> Patches 1 and 3 through 6 are
>
> Reviewed-by: Ian Romanick
>
Thanks!
> I'm sending out a comment on patch 2.
>
> On 04/27/2016 05:41 AM, Jason Ekstrand wrote:
> > I think things started out consistent when we first merged NIR since
> th
Patches 1 and 3 through 6 are
Reviewed-by: Ian Romanick
I'm sending out a comment on patch 2.
On 04/27/2016 05:41 AM, Jason Ekstrand wrote:
> I think things started out consistent when we first merged NIR since there
> weren't a lot of helpers. Over time, however, more nir_foreach helpers
> ha
Patches 1, 4 and 5 need rebasing.
Patches 2, 3 and 6 are:
Reviewed-by: Eduardo Lima Mitev
Thanks for fixing this! it has annoyed me too.
Eduardo
On 04/27/2016 05:41 AM, Jason Ekstrand wrote:
> I think things started out consistent when we first merged NIR since there
> weren't a lot of helper
I think things started out consistent when we first merged NIR since there
weren't a lot of helpers. Over time, however, more nir_foreach helpers
have been added and they haven't had a consistent argument order. This has
been annoying me for a while ("Which way does this one work again?") and
thi
