Re: [Mesa-dev] [PATCH 0/6] Mesa/Gallium vertex array state optimizations

2011-02-14 Thread José Fonseca
Marek, Apart of some subtleties with removing pipe_vertex_buffer::max_index, I think this looks great. I'm OK with addressing the pipe_vertex_buffer::max_index issues after commiting this series, as well behaved applications should not be affected. Jose On Sat, 2011-02-12 at 11:05 -0800, Marek

Re: [Mesa-dev] [PATCH 0/6] Mesa/Gallium vertex array state optimizations

2011-02-14 Thread Keith Whitwell
On Sun, 2011-02-13 at 22:04 +0100, Marek Olšák wrote: > Keith, > > Yes, they will. If vertex buffers are not re-set in st_draw_vbo, > redefine_user_buffer is called for each user buffer which is set and that > tells a driver which buffer ranges need to be re-uploaded. This can be found > in the la

Re: [Mesa-dev] [PATCH 0/6] Mesa/Gallium vertex array state optimizations

2011-02-13 Thread Marek Olšák
On Sun, Feb 13, 2011 at 8:45 PM, Keith Whitwell wrote: > Marek, > > These patches look good, but have you covered the case where the > application is changing the contents of vertex arrays without > rebinding/notifying GL in any way? > > eg. an app could do: > > memcpy(varray, foo, ...); > gl

Re: [Mesa-dev] [PATCH 0/6] Mesa/Gallium vertex array state optimizations

2011-02-13 Thread Keith Whitwell
(...); with these changes will drivers still notice the difference? Keith - Original Message - From: "Marek Olšák" To: mesa-dev@lists.freedesktop.org Sent: Saturday, February 12, 2011 7:05:27 PM Subject: [Mesa-dev] [PATCH 0/6] Mesa/Gallium vertex array state optimizations Hi,

[Mesa-dev] [PATCH 0/6] Mesa/Gallium vertex array state optimizations

2011-02-12 Thread Marek Olšák
Hi, this patch series optimizes vertex array state changes in Mesa/Gallium. The problem with the vbo module and st/mesa is that it re-binds vertex arrays every draw operation instead of only when they get changed by the application, and this series aims to address that issue. Some new issues aros