Re: [Mesa-dev] [PATCH 0/6] Fix Various Compilation Issues With Bindless

2018-07-19 Thread Rhys Perry
I think it needs more review and for the feedback on the first and second patches to be addressed before being pushed? I'm not a member of mesa group on the Gitlab, so I can't anyway. On Thu, Jul 19, 2018 at 11:14 PM, Marek Olšák wrote: > Hi, > > Do you plan to push this? > > Marek > > On Wed,

Re: [Mesa-dev] [PATCH 0/6] Fix Various Compilation Issues With Bindless

2018-07-19 Thread Marek Olšák
Hi, Do you plan to push this? Marek On Wed, Jun 6, 2018 at 3:55 PM, Rhys Perry wrote: > Previously, there were some errors in the compiler's implementation of > ARB_bindless_texture, mostly related to usage of bound image or sampler > handles allowed by ARB_bindless_texture, resulting in assert

Re: [Mesa-dev] [PATCH 0/6] Fix Various Compilation Issues With Bindless

2018-06-30 Thread Marek Olšák
On Sat, Jun 30, 2018 at 10:56 PM, Karol Herbst wrote: > On Mon, Jun 11, 2018 at 5:10 PM, Marek Olšák wrote: >> The series is OK with me, even though radeonsi can't support the new >> opcodes. >> > > How would you handle the case when a local variable might get a > bindless or a non bindless sampl

Re: [Mesa-dev] [PATCH 0/6] Fix Various Compilation Issues With Bindless

2018-06-30 Thread Karol Herbst
On Mon, Jun 11, 2018 at 5:10 PM, Marek Olšák wrote: > The series is OK with me, even though radeonsi can't support the new > opcodes. > How would you handle the case when a local variable might get a bindless or a non bindless sampler value assigned? Meaning, how can a compliant implementation of

Re: [Mesa-dev] [PATCH 0/6] Fix Various Compilation Issues With Bindless

2018-06-11 Thread Marek Olšák
The series is OK with me, even though radeonsi can't support the new opcodes. Marek On Mon, Jun 11, 2018 at 6:24 AM, Rhys Perry wrote: > Ping to those who seem appropriate for this patch in case it was forgotten > or missed. > ___ mesa-dev mailing lis

[Mesa-dev] [PATCH 0/6] Fix Various Compilation Issues With Bindless

2018-06-11 Thread Rhys Perry
Ping to those who seem appropriate for this patch in case it was forgotten or missed. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 0/6] Fix Various Compilation Issues With Bindless

2018-06-06 Thread Rhys Perry
Oops, I meant r-values, not l-values. Seems to meaning of the word in my head changed at some point. On Wed, Jun 6, 2018 at 8:55 PM, Rhys Perry wrote: > Previously, there were some errors in the compiler's implementation of > ARB_bindless_texture, mostly related to usage of bound image or sampler

[Mesa-dev] [PATCH 0/6] Fix Various Compilation Issues With Bindless

2018-06-06 Thread Rhys Perry
Previously, there were some errors in the compiler's implementation of ARB_bindless_texture, mostly related to usage of bound image or sampler handles allowed by ARB_bindless_texture, resulting in assertions or compilation errors. This series fixes following issues found in mesa: - Assertions when