Re: [Mesa-dev] [PATCH 0/2] nir: Move the si vote lowering to common code

2018-03-13 Thread Jason Ekstrand
On Tue, Mar 13, 2018 at 11:39 AM, Bas Nieuwenhuizen wrote: > Thanks a lot! > You're welcome. Classic case of writing code is easier than reviewing it. :-) > Reviewed-by: Bas Nieuwenhuizen > Thanks! Pushed. > for the series. > > On Sat, Mar 10, 2018 at 7:42 PM, Jason Ekstrand > wrote: >

Re: [Mesa-dev] [PATCH 0/2] nir: Move the si vote lowering to common code

2018-03-13 Thread Bas Nieuwenhuizen
Thanks a lot! Reviewed-by: Bas Nieuwenhuizen for the series. On Sat, Mar 10, 2018 at 7:42 PM, Jason Ekstrand wrote: > On Sat, Mar 10, 2018 at 10:18 AM, Jason Ekstrand > wrote: >> >> This tiny series moves the pass that Bas wrote for lowering vote >> instructions to ballots into common code.

Re: [Mesa-dev] [PATCH 0/2] nir: Move the si vote lowering to common code

2018-03-10 Thread Jason Ekstrand
On Sat, Mar 10, 2018 at 10:18 AM, Jason Ekstrand wrote: > This tiny series moves the pass that Bas wrote for lowering vote > instructions to ballots into common code. As you can see from the diffstat > below, it cuts the size of the pass in half by removing boilerplate. The > new version (in ni

[Mesa-dev] [PATCH 0/2] nir: Move the si vote lowering to common code

2018-03-10 Thread Jason Ekstrand
This tiny series moves the pass that Bas wrote for lowering vote instructions to ballots into common code. As you can see from the diffstat below, it cuts the size of the pass in half by removing boilerplate. The new version (in nir_lower_subgroups) also contains two bugfixes: 1) The old pass w