Re: [Mesa-dev] [PATCH] xa: don't leak fences

2015-08-05 Thread Thomas Hellstrom
Hi! On 07/10/2015 01:12 PM, Marek Olšák wrote: > I wonder... do we still need XA considering that everybody can just > use glamor instead? > > Marek Just back from vacation so I late reply. In the case of VMware/vmwgfx, the rendering setup latency is huge. Glamor tries to accelerate everything.

Re: [Mesa-dev] [PATCH] xa: don't leak fences

2015-07-10 Thread Rob Clark
On Fri, Jul 10, 2015 at 6:20 PM, Eric Anholt wrote: > Rob Clark writes: > >> well, freedreno and vmware ddx still use XA.. they both could probably >> be ported to use glamor instead, but that hasn't been done yet.. >> >> At least for freedreno with upstream drm/kms driver, one can just use >> -m

Re: [Mesa-dev] [PATCH] xa: don't leak fences

2015-07-10 Thread Eric Anholt
Rob Clark writes: > well, freedreno and vmware ddx still use XA.. they both could probably > be ported to use glamor instead, but that hasn't been done yet.. > > At least for freedreno with upstream drm/kms driver, one can just use > -modesetting ddx instead. But that doesn't work w/ android fbd

Re: [Mesa-dev] [PATCH] xa: don't leak fences

2015-07-10 Thread Rob Clark
well, freedreno and vmware ddx still use XA.. they both could probably be ported to use glamor instead, but that hasn't been done yet.. At least for freedreno with upstream drm/kms driver, one can just use -modesetting ddx instead. But that doesn't work w/ android fbdev driver. I need to check a

Re: [Mesa-dev] [PATCH] xa: don't leak fences

2015-07-10 Thread Marek Olšák
I wonder... do we still need XA considering that everybody can just use glamor instead? Marek On Wed, Jul 8, 2015 at 7:39 PM, Rob Clark wrote: > From: Rob Clark > > XA was never unref'ing last_fence in the various call paths to > pipe->flush(). Add this to xa_context_flush() and update the ot

[Mesa-dev] [PATCH] xa: don't leak fences

2015-07-08 Thread Rob Clark
From: Rob Clark XA was never unref'ing last_fence in the various call paths to pipe->flush(). Add this to xa_context_flush() and update the other open-coded calls to pipe->flush() to use xa_context_flush() instead. This fixes a memory leak reported with xf86-video-freedreno. Reported-by: Nicol