Jon Turney writes:
> per POSIX, limits.h may define PAGE_SIZE when the value is not indeterminate
>
> v2: just change the variable name, since there's no intended correlation
> here between this value and the machine's actual page size.
>
> Cc: Scott D Phillips
> Signed-off-by: Jon Turney
Revi
On 05/07/2018 16:13, Eric Engestrom wrote:
On Thursday, 2018-07-05 15:52:01 +0100, Jon Turney wrote:
per POSIX, limits.h may define PAGE_SIZE when the value is not indeterminate
"may define" -> don't you need #ifdef around #undef?
Annoyingly, I though exactly this, and then forgot :(
Patch
per POSIX, limits.h may define PAGE_SIZE when the value is not indeterminate
v2: just change the variable name, since there's no intended correlation
here between this value and the machine's actual page size.
Cc: Scott D Phillips
Signed-off-by: Jon Turney
---
src/util/tests/vma/vma_random_tes
On Thursday, 2018-07-05 15:52:01 +0100, Jon Turney wrote:
> per POSIX, limits.h may define PAGE_SIZE when the value is not indeterminate
"may define" -> don't you need #ifdef around #undef?
>
> Cc: Scott D Phillips
> Signed-off-by: Jon Turney
> ---
> src/util/tests/vma/vma_random_test.cpp | 1
per POSIX, limits.h may define PAGE_SIZE when the value is not indeterminate
Cc: Scott D Phillips
Signed-off-by: Jon Turney
---
src/util/tests/vma/vma_random_test.cpp | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/util/tests/vma/vma_random_test.cpp
b/src/util/tests/vma/vma_random_test