Re: [Mesa-dev] [PATCH] vma/tests: Fix compilation if limits.h defines PAGE_SIZE (v2)

2018-07-06 Thread Scott D Phillips
Jon Turney writes: > per POSIX, limits.h may define PAGE_SIZE when the value is not indeterminate > > v2: just change the variable name, since there's no intended correlation > here between this value and the machine's actual page size. > > Cc: Scott D Phillips > Signed-off-by: Jon Turney Revi

Re: [Mesa-dev] [PATCH] vma/tests: Fix compilation if limits.h defines PAGE_SIZE

2018-07-05 Thread Jon Turney
On 05/07/2018 16:13, Eric Engestrom wrote: On Thursday, 2018-07-05 15:52:01 +0100, Jon Turney wrote: per POSIX, limits.h may define PAGE_SIZE when the value is not indeterminate "may define" -> don't you need #ifdef around #undef? Annoyingly, I though exactly this, and then forgot :( Patch

[Mesa-dev] [PATCH] vma/tests: Fix compilation if limits.h defines PAGE_SIZE (v2)

2018-07-05 Thread Jon Turney
per POSIX, limits.h may define PAGE_SIZE when the value is not indeterminate v2: just change the variable name, since there's no intended correlation here between this value and the machine's actual page size. Cc: Scott D Phillips Signed-off-by: Jon Turney --- src/util/tests/vma/vma_random_tes

Re: [Mesa-dev] [PATCH] vma/tests: Fix compilation if limits.h defines PAGE_SIZE

2018-07-05 Thread Eric Engestrom
On Thursday, 2018-07-05 15:52:01 +0100, Jon Turney wrote: > per POSIX, limits.h may define PAGE_SIZE when the value is not indeterminate "may define" -> don't you need #ifdef around #undef? > > Cc: Scott D Phillips > Signed-off-by: Jon Turney > --- > src/util/tests/vma/vma_random_test.cpp | 1

[Mesa-dev] [PATCH] vma/tests: Fix compilation if limits.h defines PAGE_SIZE

2018-07-05 Thread Jon Turney
per POSIX, limits.h may define PAGE_SIZE when the value is not indeterminate Cc: Scott D Phillips Signed-off-by: Jon Turney --- src/util/tests/vma/vma_random_test.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/util/tests/vma/vma_random_test.cpp b/src/util/tests/vma/vma_random_test