Re: [Mesa-dev] [PATCH] vl: Initialize pipe_vertex_buffer.user_buffer fields.

2012-05-14 Thread Marek Olšák
On Mon, May 14, 2012 at 12:14 PM, Christoph Bumiller wrote: > On 14.05.2012 09:25, Jose Fonseca wrote: >> Looks good. Thanks Vinson. >> >> Joe > > Actually, all the user_buffer pointers have a comment "/**< pointer to a > user buffer if buffer == NULL */", so you wouldn't actually have to > initia

Re: [Mesa-dev] [PATCH] vl: Initialize pipe_vertex_buffer.user_buffer fields.

2012-05-14 Thread Jose Fonseca
- Original Message - > On 14.05.2012 09:25, Jose Fonseca wrote: > > Looks good. Thanks Vinson. > > > > Joe > > Actually, all the user_buffer pointers have a comment "/**< pointer > to a > user buffer if buffer == NULL */", so you wouldn't actually have to > initialize them if buffer is gua

Re: [Mesa-dev] [PATCH] vl: Initialize pipe_vertex_buffer.user_buffer fields.

2012-05-14 Thread Christoph Bumiller
On 14.05.2012 09:25, Jose Fonseca wrote: > Looks good. Thanks Vinson. > > Joe Actually, all the user_buffer pointers have a comment "/**< pointer to a user buffer if buffer == NULL */", so you wouldn't actually have to initialize them if buffer is guaranteed to be non-NULL, and checking for user_b

Re: [Mesa-dev] [PATCH] vl: Initialize pipe_vertex_buffer.user_buffer fields.

2012-05-14 Thread Jose Fonseca
Looks good. Thanks Vinson. Joe - Original Message - > Fix uninitialized scalar variable defects reported by Coverity. > > Signed-off-by: Vinson Lee > --- > src/gallium/auxiliary/vl/vl_vertex_buffers.c |4 > 1 file changed, 4 insertions(+) > > diff --git a/src/gallium/auxiliar

[Mesa-dev] [PATCH] vl: Initialize pipe_vertex_buffer.user_buffer fields.

2012-05-13 Thread Vinson Lee
Fix uninitialized scalar variable defects reported by Coverity. Signed-off-by: Vinson Lee --- src/gallium/auxiliary/vl/vl_vertex_buffers.c |4 1 file changed, 4 insertions(+) diff --git a/src/gallium/auxiliary/vl/vl_vertex_buffers.c b/src/gallium/auxiliary/vl/vl_vertex_buffers.c index