Re: [Mesa-dev] [PATCH] virgl: don't mark buffers as unclean after a write

2018-11-20 Thread Gurchetan Singh
On Tue, Nov 20, 2018 at 3:34 PM Ilia Mirkin wrote: > > I'm unfamiliar with the surrounding code, but wanted to point out that > a single buffer may be mapped as a SSBO, UBO, TBO, etc. > transfer_map/unmap isn't really aware of how the buffer is used. You > can, however, keep track of such bindings

Re: [Mesa-dev] [PATCH] virgl: don't mark buffers as unclean after a write

2018-11-20 Thread Ilia Mirkin
I'm unfamiliar with the surrounding code, but wanted to point out that a single buffer may be mapped as a SSBO, UBO, TBO, etc. transfer_map/unmap isn't really aware of how the buffer is used. You can, however, keep track of such bindings on either the resource or the context, and know that buffer X

[Mesa-dev] [PATCH] virgl: don't mark buffers as unclean after a write

2018-11-20 Thread Gurchetan Singh
Texture buffers and SSBOs are always unclean, while other buffers are not modified by compute/rendering. This improves dEQP-GLES3.performance.buffer.data_upload.function_call.map_buffer_range.new_specified_buffer.flag_write_full.stream_draw from 9.58 MB/s to 451.17 MB/s. Regression tested using