Re: [Mesa-dev] [PATCH] virgl: clear render state before submitting clear command

2018-05-08 Thread Gert Wollny
Am Montag, den 07.05.2018, 18:25 -0700 schrieb Gurchetan Singh: > In vrend_clear, we already save and restore colormasks and stencils: > > https://cgit.freedesktop.org/virglrenderer/commit/?id=b75e0a1dabdfbda > 44c310a69026a9dbd7d980294 > https://cgit.freedesktop.org/virglrenderer/commit/?id=252b0

Re: [Mesa-dev] [PATCH] virgl: clear render state before submitting clear command

2018-05-08 Thread Gert Wollny
Am Dienstag, den 08.05.2018, 16:38 +1000 schrieb Dave Airlie: > > Care to elaborate here? Nothing in gallium or virgl is really set in > stone we should be able to engineer new interfaces if needed, they > just might take some time. Taking Mareks comment [1] into account, I wouldn't want to try d

Re: [Mesa-dev] [PATCH] virgl: clear render state before submitting clear command

2018-05-07 Thread Dave Airlie
On 8 May 2018 at 16:26, Gert Wollny wrote: > Am Montag, den 07.05.2018, 18:25 -0700 schrieb Gurchetan Singh: >> In vrend_clear, we already save and restore colormasks and stencils: >> >> https://cgit.freedesktop.org/virglrenderer/commit/?id=b75e0a1dabdfbda >> 44c310a69026a9dbd7d980294 >> https://c

Re: [Mesa-dev] [PATCH] virgl: clear render state before submitting clear command

2018-05-07 Thread Gert Wollny
Am Montag, den 07.05.2018, 18:25 -0700 schrieb Gurchetan Singh: > In vrend_clear, we already save and restore colormasks and stencils: > > https://cgit.freedesktop.org/virglrenderer/commit/?id=b75e0a1dabdfbda > 44c310a69026a9dbd7d980294 > https://cgit.freedesktop.org/virglrenderer/commit/?id=252b0

Re: [Mesa-dev] [PATCH] virgl: clear render state before submitting clear command

2018-05-07 Thread Gurchetan Singh
In vrend_clear, we already save and restore colormasks and stencils: https://cgit.freedesktop.org/virglrenderer/commit/?id=b75e0a1dabdfbda44c310a69026a9dbd7d980294 https://cgit.freedesktop.org/virglrenderer/commit/?id=252b00d77c30ce39608c1a9de18523cbdcaca623 It would be nice if we can put everyth

[Mesa-dev] [PATCH] virgl: clear render state before submitting clear command

2018-05-07 Thread Gert Wollny
Virgl/virglrenderer implements the gallium clear command via a call to glClear. However, gallium clear does not take render states like e.g. RASTERIZER_DISCARD into account, but glClear does, and gallium st_Clear does not updated the latest rendering state on the host. Hence, in order to properly e