Re: [Mesa-dev] [PATCH] vbo: Set FLUSH_UPDATE_CURRENT when setting vertex attibutes

2010-09-14 Thread Kristian Høgsberg
2010/9/14 Chia-I Wu : > 2010/9/14 Kristian Høgsberg : >> 2010/9/14 Chia-I Wu : >>> 2010/9/14 Kristian Høgsberg : 2010/9/13 keith whitwell : > Hey Kristian, > > The first question is whether this is necessary - from vague memory I > have an idea that current attributes need not

Re: [Mesa-dev] [PATCH] vbo: Set FLUSH_UPDATE_CURRENT when setting vertex attibutes

2010-09-14 Thread Keith Whitwell
On Tue, 2010-09-14 at 08:18 -0700, Chia-I Wu wrote: > 2010/9/14 Kristian Høgsberg : > > 2010/9/14 Chia-I Wu : > >> 2010/9/14 Kristian Høgsberg : > >>> 2010/9/13 keith whitwell : > Hey Kristian, > > The first question is whether this is necessary - from vague memory I > have an i

Re: [Mesa-dev] [PATCH] vbo: Set FLUSH_UPDATE_CURRENT when setting vertex attibutes

2010-09-14 Thread Chia-I Wu
2010/9/14 Kristian Høgsberg : > 2010/9/14 Chia-I Wu : >> 2010/9/14 Kristian Høgsberg : >>> 2010/9/13 keith whitwell : Hey Kristian, The first question is whether this is necessary - from vague memory I have an idea that current attributes need not be updated by vertex buffe

Re: [Mesa-dev] [PATCH] vbo: Set FLUSH_UPDATE_CURRENT when setting vertex attibutes

2010-09-14 Thread Kristian Høgsberg
2010/9/14 Chia-I Wu : > 2010/9/14 Kristian Høgsberg : >> 2010/9/13 keith whitwell : >>> Hey Kristian, >>> >>> The first question is whether this is necessary - from vague memory I >>> have an idea that current attributes need not be updated by vertex >>> buffer rendering - ie. it's optional/impleme

Re: [Mesa-dev] [PATCH] vbo: Set FLUSH_UPDATE_CURRENT when setting vertex attibutes

2010-09-14 Thread Chia-I Wu
2010/9/14 Kristian Høgsberg : > 2010/9/13 keith whitwell : >> Hey Kristian, >> >> The first question is whether this is necessary - from vague memory I >> have an idea that current attributes need not be updated by vertex >> buffer rendering - ie. it's optional/implementation-dependent. >> >> I ass

Re: [Mesa-dev] [PATCH] vbo: Set FLUSH_UPDATE_CURRENT when setting vertex attibutes

2010-09-13 Thread Kristian Høgsberg
2010/9/13 keith whitwell : > Hey Kristian, > > The first question is whether this is necessary - from vague memory I > have an idea that current attributes need not be updated by vertex > buffer rendering - ie. it's optional/implementation-dependent. > > I assume you're concerned with the case wher

Re: [Mesa-dev] [PATCH] vbo: Set FLUSH_UPDATE_CURRENT when setting vertex attibutes

2010-09-13 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 keith whitwell wrote: > Hey Kristian, > > The first question is whether this is necessary - from vague memory I > have an idea that current attributes need not be updated by vertex > buffer rendering - ie. it's optional/implementation-dependent. > >

Re: [Mesa-dev] [PATCH] vbo: Set FLUSH_UPDATE_CURRENT when setting vertex attibutes

2010-09-13 Thread keith whitwell
Hey Kristian, The first question is whether this is necessary - from vague memory I have an idea that current attributes need not be updated by vertex buffer rendering - ie. it's optional/implementation-dependent. I assume you're concerned with the case where you have something like // ctx->C

[Mesa-dev] [PATCH] vbo: Set FLUSH_UPDATE_CURRENT when setting vertex attibutes

2010-09-13 Thread Kristian Høgsberg
Setting constant vertex attributes with glDrawArrays() doesn't work right because the last attribute isn't copied to ctx->Current. Typically, only the last attribute doesn't get set, since vbo_exec_wrap_upgrade_vertex() ends up getting called when setting a new attribute, and it will copy all prev