Re: [Mesa-dev] [PATCH] various: Fix missing DumpModule with recent LLVM.

2017-01-28 Thread Bas Nieuwenhuizen
You're right. Saw that it wasn't in 3.3 and just kept using the DumpModule in the versions where it was possible to avoid unforeseen regressions in old LLVM versions . You're right about radeonsi+radv only supporting 3.6+, and as it is availabe from 3.4 that saves having both variants. I'll change

Re: [Mesa-dev] [PATCH] various: Fix missing DumpModule with recent LLVM.

2017-01-28 Thread Roland Scheidegger
Maybe should use the new version for older llvm versions too? I think it would work back to around llvm 3.4 or 3.5. Meaning you don't need a ifdef for the radeon drivers. Or ist there any disadvantage of this versus the older method? Roland Am 28.01.2017 um 17:40 schrieb Bas Nieuwenhuizen: > Sinc

[Mesa-dev] [PATCH] various: Fix missing DumpModule with recent LLVM.

2017-01-28 Thread Bas Nieuwenhuizen
Since LLVM revision 293359 DumpModule gets only implemented when either a debug build or LLVM_ENABLE_DUMP is set. This patch adds a direct replacement for the function for radv and radeonsi, However, as I don't know a good place to put common LLVM code for all three I inlined the implementation fo