Re: [Mesa-dev] [PATCH] util: import sha1 implementation from OpenBSD

2017-02-07 Thread Emil Velikov
On 13 January 2017 at 21:59, Jason Ekstrand wrote: > Also, something I would like to see (maybe a follow-on patch?) would a > change to the mesa internal API to be able to put the SHA context on the > stack and not need to malloc it. It's not really a memory or cycle-saving > thing so much as it

Re: [Mesa-dev] [PATCH] util: import sha1 implementation from OpenBSD

2017-01-18 Thread Jason Ekstrand
On Jan 18, 2017 8:07 AM, "Emil Velikov" wrote: On 18 January 2017 at 09:43, Timothy Arceri wrote: > I'm all for > importing an implementation I just wanted to be sure we make a good > choice as we will likely be stuck with it for a long time. > Would you like to give it some more testing/benchm

Re: [Mesa-dev] [PATCH] util: import sha1 implementation from OpenBSD

2017-01-18 Thread Emil Velikov
On 18 January 2017 at 09:43, Timothy Arceri wrote: > I'm all for > importing an implementation I just wanted to be sure we make a good > choice as we will likely be stuck with it for a long time. > Would you like to give it some more testing/benchmarking, or I can consider this ack-by ;-) Thanks

Re: [Mesa-dev] [PATCH] util: import sha1 implementation from OpenBSD

2017-01-18 Thread Emil Velikov
On 18 January 2017 at 09:57, Steven Newbury wrote: > On Wed, 2017-01-18 at 20:43 +1100, Timothy Arceri wrote: >> On Wed, 2017-01-18 at 08:30 +, Steven Newbury wrote > [SNIP] >> > >> > Why not leave in a build time option for whichever is the fastest >> > (non- >> > OpenSSL) external SHA1 imple

Re: [Mesa-dev] [PATCH] util: import sha1 implementation from OpenBSD

2017-01-18 Thread Steven Newbury
On Wed, 2017-01-18 at 20:43 +1100, Timothy Arceri wrote: > On Wed, 2017-01-18 at 08:30 +, Steven Newbury wrote [SNIP] > > > > Why not leave in a build time option for whichever is the fastest > > (non- > > OpenSSL) external SHA1 implementation but default or fallback to > > whatever gets pulle

Re: [Mesa-dev] [PATCH] util: import sha1 implementation from OpenBSD

2017-01-18 Thread Timothy Arceri
On Wed, 2017-01-18 at 08:30 +, Steven Newbury wrote: > On Mon, 2017-01-16 at 16:52 +0300, Vladislav Egorov wrote: > > > > 16.01.2017 16:13, Emil Velikov пишет: > > > Hi Vladislav, > > > > > > On 14 January 2017 at 01:50, Vladislav Egorov > > om > > > > wrote: > > > > 14.01.2017 01:45, Timoth

Re: [Mesa-dev] [PATCH] util: import sha1 implementation from OpenBSD

2017-01-18 Thread Steven Newbury
On Mon, 2017-01-16 at 16:52 +0300, Vladislav Egorov wrote: > > 16.01.2017 16:13, Emil Velikov пишет: > > Hi Vladislav, > > > > On 14 January 2017 at 01:50, Vladislav Egorov > > wrote: > > > 14.01.2017 01:45, Timothy Arceri пишет: > > > > I'm asking for a chance to test before we jump in, its pro

Re: [Mesa-dev] [PATCH] util: import sha1 implementation from OpenBSD

2017-01-16 Thread Vladislav Egorov
16.01.2017 16:13, Emil Velikov пишет: Hi Vladislav, On 14 January 2017 at 01:50, Vladislav Egorov wrote: 14.01.2017 01:45, Timothy Arceri пишет: I'm asking for a chance to test before we jump in, its probably not a big deal and I may even still be able to reduce my use of hashing but it wou

Re: [Mesa-dev] [PATCH] util: import sha1 implementation from OpenBSD

2017-01-16 Thread Emil Velikov
On 14 January 2017 at 06:25, Jonathan Gray wrote: > On Fri, Jan 13, 2017 at 04:51:31PM +, Emil Velikov wrote: >> From: Emil Velikov >> >> At the moment we support 5+ different implementations each with varying >> amount of bugs - from thread safely problems [1], to outright broken >> implemen

Re: [Mesa-dev] [PATCH] util: import sha1 implementation from OpenBSD

2017-01-16 Thread Emil Velikov
Hi Vladislav, On 14 January 2017 at 01:50, Vladislav Egorov wrote: > 14.01.2017 01:45, Timothy Arceri пишет: >> >> I'm asking for a chance to test before we jump in, its probably not a >> big deal and I may even still be able to reduce my use of hashing but >> it would be nice to be given a few d

Re: [Mesa-dev] [PATCH] util: import sha1 implementation from OpenBSD

2017-01-15 Thread Tapani Pälli
Yes! Simplifies current situation quite a bit and makes Vulkan Android build possible, I'll submit that if/when this one lands. There's one thing that caused problems with Android, I've marked it below .. with that removed; Acked-by: Tapani Pälli On 01/13/2017 06:51 PM, Emil Velikov wrote:

Re: [Mesa-dev] [PATCH] util: import sha1 implementation from OpenBSD

2017-01-14 Thread Timothy Arceri
On Sat, 2017-01-14 at 04:50 +0300, Vladislav Egorov wrote: > 14.01.2017 01:45, Timothy Arceri пишет: > > I'm asking for a chance to test before we jump in, its probably not > > a > > big deal and I may even still be able to reduce my use of hashing > > but > > it would be nice to be given a few day

Re: [Mesa-dev] [PATCH] util: import sha1 implementation from OpenBSD

2017-01-13 Thread Jonathan Gray
On Fri, Jan 13, 2017 at 04:51:31PM +, Emil Velikov wrote: > From: Emil Velikov > > At the moment we support 5+ different implementations each with varying > amount of bugs - from thread safely problems [1], to outright broken > implementation(s) [2] > > In order to accommodate these we have

Re: [Mesa-dev] [PATCH] util: import sha1 implementation from OpenBSD

2017-01-13 Thread Vladislav Egorov
14.01.2017 01:45, Timothy Arceri пишет: I'm asking for a chance to test before we jump in, its probably not a big deal and I may even still be able to reduce my use of hashing but it would be nice to be given a few days to test and even explore alternatives before jumping on this implementation.

Re: [Mesa-dev] [PATCH] util: import sha1 implementation from OpenBSD

2017-01-13 Thread Emil Velikov
Thanks for the comments gents. This is the type of discussion I was aiming at. On 13 January 2017 at 22:45, Timothy Arceri wrote: > On Fri, 2017-01-13 at 14:32 -0800, Jason Ekstrand wrote: >> On Fri, Jan 13, 2017 at 2:18 PM, Timothy Arceri > bora.com> wrote: >> > On Fri, 2017-01-13 at 13:59 -080

Re: [Mesa-dev] [PATCH] util: import sha1 implementation from OpenBSD

2017-01-13 Thread Timothy Arceri
On Fri, 2017-01-13 at 14:32 -0800, Jason Ekstrand wrote: > On Fri, Jan 13, 2017 at 2:18 PM, Timothy Arceri bora.com> wrote: > > On Fri, 2017-01-13 at 13:59 -0800, Jason Ekstrand wrote: > > > On Fri, Jan 13, 2017 at 11:22 AM, Vladislav Egorov > ail. > > > com> wrote: > > > > 13.01.2017 19:51, Emil

Re: [Mesa-dev] [PATCH] util: import sha1 implementation from OpenBSD

2017-01-13 Thread Jason Ekstrand
On Fri, Jan 13, 2017 at 2:18 PM, Timothy Arceri < timothy.arc...@collabora.com> wrote: > On Fri, 2017-01-13 at 13:59 -0800, Jason Ekstrand wrote: > > On Fri, Jan 13, 2017 at 11:22 AM, Vladislav Egorov > com> wrote: > > > 13.01.2017 19:51, Emil Velikov пишет: > > > > From: Emil Velikov > > > > >

Re: [Mesa-dev] [PATCH] util: import sha1 implementation from OpenBSD

2017-01-13 Thread Vladislav Egorov
14.01.2017 00:17, Matt Turner пишет: On Fri, Jan 13, 2017 at 1:01 PM, Vladislav Egorov wrote: 2017-01-13 22:43 GMT+03:00 Emil Velikov : On 13 January 2017 at 19:22, Vladislav Egorov wrote: 13.01.2017 19:51, Emil Velikov пишет: From: Emil Velikov At the moment we support 5+ different imp

Re: [Mesa-dev] [PATCH] util: import sha1 implementation from OpenBSD

2017-01-13 Thread Timothy Arceri
On Fri, 2017-01-13 at 13:59 -0800, Jason Ekstrand wrote: > On Fri, Jan 13, 2017 at 11:22 AM, Vladislav Egorov com> wrote: > > 13.01.2017 19:51, Emil Velikov пишет: > > > From: Emil Velikov > > > > > > At the moment we support 5+ different implementations each with > > > varying > > > amount of b

Re: [Mesa-dev] [PATCH] util: import sha1 implementation from OpenBSD

2017-01-13 Thread Jason Ekstrand
On Fri, Jan 13, 2017 at 11:22 AM, Vladislav Egorov wrote: > 13.01.2017 19:51, Emil Velikov пишет: > >> From: Emil Velikov >> >> At the moment we support 5+ different implementations each with varying >> amount of bugs - from thread safely problems [1], to outright broken >> implementation(s) [2]

Re: [Mesa-dev] [PATCH] util: import sha1 implementation from OpenBSD

2017-01-13 Thread Matt Turner
On Fri, Jan 13, 2017 at 1:01 PM, Vladislav Egorov wrote: > 2017-01-13 22:43 GMT+03:00 Emil Velikov : >> >> On 13 January 2017 at 19:22, Vladislav Egorov wrote: >> > 13.01.2017 19:51, Emil Velikov пишет: >> >> >> >> From: Emil Velikov >> >> >> >> At the moment we support 5+ different implementati

Re: [Mesa-dev] [PATCH] util: import sha1 implementation from OpenBSD

2017-01-13 Thread Matt Turner
I am generally in favor of this for all the reasons you've described. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] util: import sha1 implementation from OpenBSD

2017-01-13 Thread Vladislav Egorov
2017-01-13 22:43 GMT+03:00 Emil Velikov : > > On 13 January 2017 at 19:22, Vladislav Egorov wrote: > > 13.01.2017 19:51, Emil Velikov пишет: > >> > >> From: Emil Velikov > >> > >> At the moment we support 5+ different implementations each with varying > >> amount of bugs - from thread safely prob

Re: [Mesa-dev] [PATCH] util: import sha1 implementation from OpenBSD

2017-01-13 Thread Matt Turner
On Fri, Jan 13, 2017 at 11:51 AM, Dylan Baker wrote: > Quoting Emil Velikov (2017-01-13 08:51:31) >> From: Emil Velikov >> >> At the moment we support 5+ different implementations each with varying >> amount of bugs - from thread safely problems [1], to outright broken >> implementation(s) [2] >>

Re: [Mesa-dev] [PATCH] util: import sha1 implementation from OpenBSD

2017-01-13 Thread Dylan Baker
Quoting Emil Velikov (2017-01-13 08:51:31) > From: Emil Velikov > > At the moment we support 5+ different implementations each with varying > amount of bugs - from thread safely problems [1], to outright broken > implementation(s) [2] > > In order to accommodate these we have 150+ lines of confi

Re: [Mesa-dev] [PATCH] util: import sha1 implementation from OpenBSD

2017-01-13 Thread Emil Velikov
On 13 January 2017 at 19:22, Vladislav Egorov wrote: > 13.01.2017 19:51, Emil Velikov пишет: >> >> From: Emil Velikov >> >> At the moment we support 5+ different implementations each with varying >> amount of bugs - from thread safely problems [1], to outright broken >> implementation(s) [2] >> >

Re: [Mesa-dev] [PATCH] util: import sha1 implementation from OpenBSD

2017-01-13 Thread Vladislav Egorov
13.01.2017 19:51, Emil Velikov пишет: From: Emil Velikov At the moment we support 5+ different implementations each with varying amount of bugs - from thread safely problems [1], to outright broken implementation(s) [2] In order to accommodate these we have 150+ lines of configure script and e

[Mesa-dev] [PATCH] util: import sha1 implementation from OpenBSD

2017-01-13 Thread Emil Velikov
From: Emil Velikov At the moment we support 5+ different implementations each with varying amount of bugs - from thread safely problems [1], to outright broken implementation(s) [2] In order to accommodate these we have 150+ lines of configure script and extra two configure toggles. Whist an act