Re: [Mesa-dev] [PATCH] util: hash_table: move NULL assert to string hashing function

2017-11-27 Thread Ian Romanick
On 11/27/2017 08:27 AM, Lionel Landwerlin wrote: > Hash maps might use pointer keys (which people surely might want to > use to hash values) in which case a 0 value is perfectly acceptable. > It's only if the hash function needs to deference the pointer that we > want to be sure it's not NULL. > >

[Mesa-dev] [PATCH] util: hash_table: move NULL assert to string hashing function

2017-11-27 Thread Lionel Landwerlin
Hash maps might use pointer keys (which people surely might want to use to hash values) in which case a 0 value is perfectly acceptable. It's only if the hash function needs to deference the pointer that we want to be sure it's not NULL. Signed-off-by: Lionel Landwerlin --- src/util/hash_table.c