Re: [Mesa-dev] [PATCH] util: Fix Clang trivial destructor check.

2016-11-14 Thread Francisco Jerez
Vinson Lee writes: > Check for Clang before GCC. > > Clang defines __GNUC__ == 4 and __GNUC_MINOR__ == 2 and matches the GCC > check but not the GCC version for trivial destructor. > > Fixes: 98ab905af0e0 ("mesa: Define introspection macro to determine > whether a type is trivially destructible."

Re: [Mesa-dev] [PATCH] util: Fix Clang trivial destructor check.

2016-11-14 Thread Edward O'Callaghan
Reviewed-by: Edward O'Callaghan On 11/14/2016 06:11 PM, Vinson Lee wrote: > Check for Clang before GCC. > > Clang defines __GNUC__ == 4 and __GNUC_MINOR__ == 2 and matches the GCC > check but not the GCC version for trivial destructor. > > Fixes: 98ab905af0e0 ("mesa: Define introspection macro

Re: [Mesa-dev] [PATCH] util: Fix Clang trivial destructor check.

2016-11-14 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Mon, Nov 14, 2016 at 8:11 AM, Vinson Lee wrote: > Check for Clang before GCC. > > Clang defines __GNUC__ == 4 and __GNUC_MINOR__ == 2 and matches the GCC > check but not the GCC version for trivial destructor. > > Fixes: 98ab905af0e0 ("mesa: Define introspectio

[Mesa-dev] [PATCH] util: Fix Clang trivial destructor check.

2016-11-13 Thread Vinson Lee
Check for Clang before GCC. Clang defines __GNUC__ == 4 and __GNUC_MINOR__ == 2 and matches the GCC check but not the GCC version for trivial destructor. Fixes: 98ab905af0e0 ("mesa: Define introspection macro to determine whether a type is trivially destructible.") Bugzilla: https://bugs.freedesk