Re: [Mesa-dev] [PATCH] u_vbuf_mgr: restore buffer offsets

2011-07-21 Thread Marek Olšák
On Thu, Jul 21, 2011 at 9:48 AM, Chia-I Wu wrote: > On Wed, Jul 20, 2011 at 11:32 PM, Marek Olšák wrote: >> Well spotted, thanks. Some comments below. >> >> On Wed, Jul 20, 2011 at 3:25 PM, Chia-I Wu wrote: >>> From: Chia-I Wu >>> >>> u_vbuf_upload_buffers modifies the buffer offsets.  If they

Re: [Mesa-dev] [PATCH] u_vbuf_mgr: restore buffer offsets

2011-07-21 Thread Chia-I Wu
On Wed, Jul 20, 2011 at 11:32 PM, Marek Olšák wrote: > Well spotted, thanks. Some comments below. > > On Wed, Jul 20, 2011 at 3:25 PM, Chia-I Wu wrote: >> From: Chia-I Wu >> >> u_vbuf_upload_buffers modifies the buffer offsets.  If they are not >> restored, and any of the vertex formats is not s

Re: [Mesa-dev] [PATCH] u_vbuf_mgr: restore buffer offsets

2011-07-20 Thread Marek Olšák
Well spotted, thanks. Some comments below. On Wed, Jul 20, 2011 at 3:25 PM, Chia-I Wu wrote: > From: Chia-I Wu > > u_vbuf_upload_buffers modifies the buffer offsets.  If they are not > restored, and any of the vertex formats is not supported natively, the > next u_vbuf_mgr_draw_begin call will t

[Mesa-dev] [PATCH] u_vbuf_mgr: restore buffer offsets

2011-07-20 Thread Chia-I Wu
From: Chia-I Wu u_vbuf_upload_buffers modifies the buffer offsets. If they are not restored, and any of the vertex formats is not supported natively, the next u_vbuf_mgr_draw_begin call will translate the vertex buffers with incorrect buffer offsets. --- src/gallium/auxiliary/util/u_vbuf_mgr.c