Re: [Mesa-dev] [PATCH] tgsi: handle indirect sampler arrays. (v2)

2015-06-23 Thread Roland Scheidegger
Am 23.06.2015 um 07:53 schrieb Dave Airlie: > On 22 June 2015 at 21:20, Roland Scheidegger wrote: >> Should there be some clamping somewhere to prevent crashes due to >> out-of-bound unit index? > > The spec says its undefined, I'm never sure if that means explode in > any way whatsoever. > > Da

Re: [Mesa-dev] [PATCH] tgsi: handle indirect sampler arrays. (v2)

2015-06-22 Thread Dave Airlie
On 22 June 2015 at 21:20, Roland Scheidegger wrote: > Should there be some clamping somewhere to prevent crashes due to > out-of-bound unit index? The spec says its undefined, I'm never sure if that means explode in any way whatsoever. Dave. ___ mesa-d

Re: [Mesa-dev] [PATCH] tgsi: handle indirect sampler arrays. (v2)

2015-06-22 Thread Roland Scheidegger
Should there be some clamping somewhere to prevent crashes due to out-of-bound unit index? In any case, Reviewed-by: Roland Scheidegger Am 22.06.2015 um 05:18 schrieb Dave Airlie: > This is required for ARB_gpu_shader5 support in softpipe. > > v2: add support to txd/txf/txq paths. > > Signed-of

[Mesa-dev] [PATCH] tgsi: handle indirect sampler arrays. (v2)

2015-06-21 Thread Dave Airlie
This is required for ARB_gpu_shader5 support in softpipe. v2: add support to txd/txf/txq paths. Signed-off-by: Dave Airlie --- src/gallium/auxiliary/tgsi/tgsi_exec.c | 42 ++ 1 file changed, 38 insertions(+), 4 deletions(-) diff --git a/src/gallium/auxiliary/tg

Re: [Mesa-dev] [PATCH] tgsi: handle indirect sampler arrays.

2015-05-27 Thread Roland Scheidegger
Am 27.05.2015 um 10:38 schrieb Dave Airlie: > This is required for ARB_gpu_shader5 support in softpipe. > > Signed-off-by: Dave Airlie > --- > src/gallium/auxiliary/tgsi/tgsi_exec.c | 23 ++- > 1 file changed, 22 insertions(+), 1 deletion(-) > > diff --git a/src/gallium/auxi

[Mesa-dev] [PATCH] tgsi: handle indirect sampler arrays.

2015-05-27 Thread Dave Airlie
This is required for ARB_gpu_shader5 support in softpipe. Signed-off-by: Dave Airlie --- src/gallium/auxiliary/tgsi/tgsi_exec.c | 23 ++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/tgsi/tgsi_exec.c b/src/gallium/auxiliary/tgsi/tgsi_ex