Re: [Mesa-dev] [PATCH] tgsi: fix rbug compile error

2010-12-13 Thread Keith Whitwell
On Sat, 2010-12-11 at 04:22 -0800, Jose Fonseca wrote: > Looks good to me FWIW. > > Usually one uses a union for avoid breaking strict-aliasing rules, but your > memcpy approach should produce just as good code with less typing. > > The only proper fix here would be to make struct tgsi_token an

Re: [Mesa-dev] [PATCH] tgsi: fix rbug compile error

2010-12-11 Thread Jose Fonseca
From: mesa-dev-bounces+jfonseca=vmware@lists.freedesktop.org [mesa-dev-bounces+jfonseca=vmware@lists.freedesktop.org] On Behalf Of Marek Olšák [mar...@gmail.com] Sent: Saturday, December 11, 2010 8:04 To: mesa-dev@lists.freedesktop.org Subject: [Mesa-dev] [PATCH] tgsi

[Mesa-dev] [PATCH] tgsi: fix rbug compile error

2010-12-11 Thread Marek Olšák
../mesa/src/gallium/auxiliary/tgsi/tgsi_parse.h:139: error: dereferencing pointer ‘tokens.25’ does break strict-aliasing rules Signed-off-by: Marek Olšák --- src/gallium/auxiliary/tgsi/tgsi_parse.h |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/gallium/auxiliary/t