Re: [Mesa-dev] [PATCH] target/d3dadapter9: make sure strings are null-terminated

2016-05-31 Thread Axel Davy
The drvid structure seems to be memset in read_descriptor, thus I don't think we need to set 0 for the last table slot. Axel Davy On 31/05/2016 03:21, Eric Engestrom wrote: From strncpy's man page: Warning: If there is no null byte among the first n bytes of src, the string placed in des

Re: [Mesa-dev] [PATCH] target/d3dadapter9: make sure strings are null-terminated

2016-05-31 Thread Emil Velikov
On 31 May 2016 at 02:21, Eric Engestrom wrote: > From strncpy's man page: > Warning: If there is no null byte among the first n bytes of src, the > string placed in dest will not be null-terminated. > > CoverityID: 1320457, 1320458, 1255671 > Change looks fine by me, although I'm not sure if

[Mesa-dev] [PATCH] target/d3dadapter9: make sure strings are null-terminated

2016-05-30 Thread Eric Engestrom
From strncpy's man page: Warning: If there is no null byte among the first n bytes of src, the string placed in dest will not be null-terminated. CoverityID: 1320457, 1320458, 1255671 Signed-off-by: Eric Engestrom --- src/gallium/targets/d3dadapter9/description.c | 39 ++---