Re: [Mesa-dev] [PATCH] swrast: Fix fixed-function fragment processing

2012-01-27 Thread Chad Versace
On 01/27/2012 03:19 PM, Brian Paul wrote: > Chad, > > I'm seeing a bunch of new warnings: Brian, sorry about that. I forgot a #include, of course. I just pushed the fix. Chad Versace chad.vers...@linux.intel.com ___ mesa-dev mailing list mesa-dev@

Re: [Mesa-dev] [PATCH] swrast: Fix fixed-function fragment processing

2012-01-27 Thread Brian Paul
Chad, I'm seeing a bunch of new warnings: In file included from swrast/s_aaline.c:470: swrast/s_aalinetemp.h: In function ‘aa_general_rgba_plot’: swrast/s_aalinetemp.h:70: warning: implicit declaration of function ‘_swrast_use_fragment_program’ swrast/s_aatriangle.c: In function ‘_swrast_set_aa_t

Re: [Mesa-dev] [PATCH] swrast: Fix fixed-function fragment processing

2012-01-27 Thread Ian Romanick
On 01/26/2012 12:46 PM, Chad Versace wrote: On i965, _mesa_ir_link_shader is never called. As a consequence, the current fragment program (ctx->FragmentProgram->_Current) exists but does not differ from the fixed function fragment program (ctx->FragmentProgram->_TexEnvProgram). This confuses swra

Re: [Mesa-dev] [PATCH] swrast: Fix fixed-function fragment processing

2012-01-26 Thread Eric Anholt
On Thu, 26 Jan 2012 12:46:03 -0800, Chad Versace wrote: > On i965, _mesa_ir_link_shader is never called. As a consequence, the > current fragment program (ctx->FragmentProgram->_Current) exists but does > not differ from the fixed function fragment program > (ctx->FragmentProgram->_TexEnvProgram)

[Mesa-dev] [PATCH] swrast: Fix fixed-function fragment processing

2012-01-26 Thread Chad Versace
On i965, _mesa_ir_link_shader is never called. As a consequence, the current fragment program (ctx->FragmentProgram->_Current) exists but does not differ from the fixed function fragment program (ctx->FragmentProgram->_TexEnvProgram). This confuses swrast. To fix the confusion, this patch replaces

Re: [Mesa-dev] [PATCH] swrast: Fix fixed-function fragment processing

2012-01-26 Thread Eric Anholt
On Wed, 25 Jan 2012 19:38:10 -0800, Chad Versace wrote: > On i965, _mesa_ir_link_shader is never called. As a consequence, > ctx->FragmentProgram->_Current exists but contains no instructions. This > greatly confuses swrast. I don't think this is valid. You're replacing checks for "is there a f

[Mesa-dev] [PATCH] swrast: Fix fixed-function fragment processing

2012-01-25 Thread Chad Versace
On i965, _mesa_ir_link_shader is never called. As a consequence, ctx->FragmentProgram->_Current exists but contains no instructions. This greatly confuses swrast. To fix the confusion, this patch replaces checks of the form if (ctx->FragmentProgram->_Current == NULL) with if (_swrast_fragm