Re: [Mesa-dev] [PATCH] swr: Fix resource leak in object.

2016-05-04 Thread Robert Foss
On 05/04/2016 08:52 AM, Rowley, Timothy O wrote: After shader compilation, the gallivm_state is owned by ShaderVariant<> and destroyed by its destructor (swr_state.h) so that the generated JIT code and gallivm_state can be freed when no longer needed. Oh. Splendid. Thanks for looking into

Re: [Mesa-dev] [PATCH] swr: Fix resource leak in object.

2016-05-04 Thread Rowley, Timothy O
After shader compilation, the gallivm_state is owned by ShaderVariant<> and destroyed by its destructor (swr_state.h) so that the generated JIT code and gallivm_state can be freed when no longer needed. > On May 3, 2016, at 5:45 PM, robert.f...@collabora.com wrote: > > From: Robert Foss > > M

[Mesa-dev] [PATCH] swr: Fix resource leak in object.

2016-05-03 Thread robert . foss
From: Robert Foss Make sure that memory allocated is free'd. Previously only the contents of the variable galliumvm was free'd, not the actual memory it points to. Coverity: 1358907 Signed-off-by: Robert Foss --- src/gallium/drivers/swr/swr_shader.cpp | 1 + 1 file changed, 1 insertion(+) dif