Re: [Mesa-dev] [PATCH] svga: refactor draw_vgpu10() function

2019-03-07 Thread Neha Bhende
Looks good to me. Just one nit pick, In definition of validate_index_buffer, extra space is required in argument list. Reviewed-by: Neha Bhende Regards, Neha Regards, Neha From: Brian Paul Sent: Thursday, March 7, 2019 3:23 PM To: mesa-dev@lists.fre

[Mesa-dev] [PATCH] svga: refactor draw_vgpu10() function

2019-03-07 Thread Brian Paul
The draw_vgpu10() function was huge. Move the code for preparing the vertex buffers and the index buffer into separate functions. --- src/gallium/drivers/svga/svga_draw.c | 246 --- 1 file changed, 141 insertions(+), 105 deletions(-) diff --git a/src/gallium/drive