Re: [Mesa-dev] [PATCH] svga: allow non-contiguous VS input declarations

2016-02-18 Thread Charmaine Lee
Reviewed-by: Charmaine Lee From: Brian Paul Sent: Thursday, February 18, 2016 12:30 PM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee Subject: [PATCH] svga: allow non-contiguous VS input declarations This fixes a glDrawPixels regression since b63fe0

[Mesa-dev] [PATCH] svga: allow non-contiguous VS input declarations

2016-02-18 Thread Brian Paul
This fixes a glDrawPixels regression since b63fe0552b5f. The new quad-drawing utility code uses 3 vertex attributes (xyz, rgba, st). For glDrawPixels path we don't use the rgba attribute so there's a gap in the TGSI VS input declarations (INPUT[0] = pos, INPUT[2] = texcoord). The TGSI->VGPU10 tra

Re: [Mesa-dev] [PATCH] svga: allow non-contiguous VS input declarations

2016-02-18 Thread Brian Paul
On 02/18/2016 11:36 AM, Charmaine Lee wrote: From: Brian Paul Sent: Thursday, February 18, 2016 7:51 AM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee Subject: [PATCH] svga: allow non-contiguous VS input declarations This fixes a glDrawPixels regression since b63fe0552b5f. The new quad

Re: [Mesa-dev] [PATCH] svga: allow non-contiguous VS input declarations

2016-02-18 Thread Charmaine Lee
>From: Brian Paul >Sent: Thursday, February 18, 2016 7:51 AM >To: mesa-dev@lists.freedesktop.org >Cc: Charmaine Lee >Subject: [PATCH] svga: allow non-contiguous VS input declarations > >This fixes a glDrawPixels regression since b63fe0552b5f. The new >quad-drawing utility code uses 3 vertex attr

[Mesa-dev] [PATCH] svga: allow non-contiguous VS input declarations

2016-02-18 Thread Brian Paul
This fixes a glDrawPixels regression since b63fe0552b5f. The new quad-drawing utility code uses 3 vertex attributes (xyz, rgba, st). For glDrawPixels path we don't use the rgba attribute so there's a gap in the TGSI VS input declarations (INPUT[0] = pos, INPUT[2] = texcoord). The TGSI->VGPU10 tra